-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Only use custom credentials for certain labels #1502
Comments
Hi there! 👋🏼 As you're new to this repo, we'd like to suggest that you read our code of conduct as well as our contribution guidelines. Thanks a bunch for opening your first issue! 🙏 |
Why wouldn't that be an option? Just use |
The reason is exactly as I stated The only thing that seems potentially related is {
"credsStore": "desktop"
}
but when mapped still fails assumedly because the "desktop" isn't something accessible to the container
I've been logged in since before I ever used Watchtower, I've tried re- |
Just remove the "credsStore" line in the config and do the login again. You can then move your config.json somewhere else and revert "credsStore" to keep using docker desktop creds store if you want. Then point watchtower to your copied config.json |
I tried that, well I tried removing the file & that didn't do anything, a restart just recreated it. I just tried with editing out the line & did a login
After which the file still had the blank lines. Since I logged in before, it added nothing to the file, logged in again with it gone, it added nothing, removed the line & logged in again, &, big surprise, no change, I'm fairly confident that that file is not going to be able to give me the needed credentials
&, FYI, in case it wasn't clear, that wasn't part of the |
Seems like you have to use
Yes, the "credsStore" setting means ”don't store credentials in here, use the program docker-credentials-XXXX instead" |
Is your feature request related to a problem? Please describe.
When running watchtower I have the option of using custom credentials
But I, like I assume most users, don't pull all my images from my private repo, most are pulled from Docker Hub.
As it stands if I set custom Repo credentials all the Docker ones give an error
If I don't set it all the private ones do
So as of how I have to set up 2 Towers, & set them each with a label to monitor on on one & off on the other. But then you can't have some that actually get ignored.
Describe the solution you'd like
It would be nice to have a
com.centurylinklabs.watchtower.custom
orcom.centurylinklabs.watchtower.credentials
label to make it so that those labeled will use the custom credentials while those not labeled will not.Either that or let us use user-defined labels so I could have something like
watchtower.credentials.johnny
for ones that update using the custom credentials argument orwatchtower.credentials.docker
to act as though no custom arguments are set.I'm sure this is less of an issue if using the Docker
config.json
but running under Docker Desktop that isn't an option.Ideally it'd be nice to be able to specify credentials for multiple custom repos, though not something I personally would use I'm sure there are those who would.
Perhaps
I'm not exactly sure how it would need to be for watchtower to use the arguments, I just gave an example to something I know I could make work in python.
Describe alternatives you've considered
The only alternative is having 2 watchtowers & using 1 with
WATCHTOWER_LABEL_ENABLE
set totrue
& the other withWATCHTOWER_LABEL_ENABLE
set tofalse
& I'm not even sure that would work properly, plus it leaves no way to have ones ignored completelyAdditional context
No response
The text was updated successfully, but these errors were encountered: