Skip to content

Commit d9d6f79

Browse files
MorrisLawJeremy L. Morris
andauthored
feat: use a more specific error type for no container info (#1115)
Co-authored-by: Jeremy L. Morris <jmorris@digitalocean.com>
1 parent ac00e48 commit d9d6f79

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

pkg/container/container.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ func (c Container) VerifyConfiguration() error {
285285

286286
containerInfo := c.ContainerInfo()
287287
if containerInfo == nil {
288-
return errorInvalidConfig
288+
return errorNoContainerInfo
289289
}
290290

291291
containerConfig := containerInfo.Config

pkg/container/container_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ var _ = Describe("the container", func() {
2323
c := mockContainerWithPortBindings()
2424
c.containerInfo = nil
2525
err := c.VerifyConfiguration()
26-
Expect(err).To(Equal(errorInvalidConfig))
26+
Expect(err).To(Equal(errorNoContainerInfo))
2727
})
2828
})
2929
When("verifying a container with no config", func() {

pkg/container/errors.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@ package container
33
import "errors"
44

55
var errorNoImageInfo = errors.New("no available image info")
6+
var errorNoContainerInfo = errors.New("no available container info")
67
var errorNoExposedPorts = errors.New("exposed ports does not match port bindings")
78
var errorInvalidConfig = errors.New("container configuration missing or invalid")

0 commit comments

Comments
 (0)