Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for seccomp filter flags #937

Merged

Conversation

saschagrunert
Copy link
Member

crun supports seccomp filter flags since containers/crun@fefabff
runc will get them with opencontainers/runc#3390
youki will get them with youki-dev/youki#733

To support them generally, we now copy the flags during the seccomp
setup, otherwise they will get lost.

crun supports seccomp filter flags since containers/crun@fefabff
runc will get them with opencontainers/runc#3390
youki will get them with youki-dev/youki#733

To support them generally, we now copy the flags during the seccomp
setup, otherwise they will get lost.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

cc @giuseppe

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Feb 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 468d7e6 into containers:main Feb 23, 2022
@saschagrunert saschagrunert deleted the seccomp-filter-flags branch February 23, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants