Update VMs, linter, fix warnings, add a "fmt" target #6502
Conversation
Drop this Dockerfile, which was used by a script which was removed before v1.14.0. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Update the linter, and add a top-level 'fmt' target to run its built-in formatters. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Fix a "that doesn't take %w" warning. Fix two "you forgot to pass that error to the formatter" warnings. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
These are internal and test packages, so this shouldn't break any of our API consumers. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Supporess "meaningless package name" warnings for exported APIs which we know are being used by our API consumers, so that we don't break them. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
openshift-ci
bot
added
kind/cleanup
nalind
changed the title
nalind
changed the title
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
Weird, renovate is supposed to create update PRs. I did a look at the last one (#6122) and it seemed it failed to delete branch somehow so it never proposed a new update afterwards
Overall this looks fine the revive,nolintlint flakes I have seen in podman as well but could never reproduce properly so didn't report it or chase down further.
Just one blocking comment on the debian name.
|
|
||
| # Image identifiers | ||
| IMAGE_SUFFIX: "c20250910t092246z-f42f41d13" | ||
| IMAGE_SUFFIX: "c20251110t154831z-f42f41d14" |
There was a problem hiding this comment.
blocker: This bumps to debian 14 so you must update DEBIAN_NAME above as well
There was a problem hiding this comment.
Thanks for catching that! Rebasing with that updated.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Now that we've got runc 1.3.3, which includes the fix that went into 1.3.2 for the flake we've been seeing, block on runc jobs again. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 04f196a
into
containers:main
3 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
How to verify it
CI should notice if we were using this Dockerfile somewhere that I didn't find.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Sometimes, suppressing a "revive" warning triggers a bogus warning from "nolintlint", so yeah, we're working around that by suppressing both of them.
Does this PR introduce a user-facing change?