Preserve nosymfollow across bind-mount flag fixups - #770
Open
tjunnone wants to merge 1 commit into
Open
Conversation
Add a nosymfollow entry to decode_mountoptions so the flag is not dropped on a fixup remount. Added a regression test, binding a `nosymfollow` tmpfs read-only (therefore forcing a fixup remount) that fails if symlink is followed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bubblewrap binds a host mount that was mounted
nosymfollow(for example systemd credential mounts), the flag is silently cleared inside the sandbox whenever the bind triggers bubblewrap's flag-fixup remount.Example:
Expected: the sandbox refuses to follow the symlink (
ELOOP), just like the host.Actual: the sandbox prints
secret, asnosymfollowwas dropped.This happens because
decode_mountoptionsparses the mount's flags from/proc/self/mountinfothrough a table that has nonosymfollowentry. The fixup remount then passes only the decoded flags andnosymfollowis cleared. The fix is to add the table entry. A test entry for the case is also added to test-run.sh for good measure.