Skip to content

Commit fbe95db

Browse files
committed
cleanup
Signed-off-by: Thomas Kooi <thomas@containerinfra.com>
1 parent e28c602 commit fbe95db

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

controllers/generatedsecret/controller.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ func (r *GeneratedSecretReconciler) SetupWithManager(mgr ctrl.Manager) error {
9696
return true
9797
},
9898
UpdateFunc: func(event event.UpdateEvent) bool {
99+
// TODO: filter out status updates if event.ObjectNew == event.ObjectNew
99100
return true
100101
},
101102
GenericFunc: func(event event.GenericEvent) bool {

controllers/generatedsecret/init.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,7 @@ func (r *GeneratedSecretReconciler) initalizeGeneratedSecret(ctx context.Context
4848
} else {
4949
fmt.Printf("created secret in ns %s/%s %q\n", secret.Namespace, secret.Name, secret.UID)
5050
}
51-
if secret.GetUID() == "" {
52-
r.Recorder.Eventf(&generatedSecret, corev1.EventTypeWarning, "Failed secret uuid compare", "Missing UUID for secret in namespace '%s/%s'", secret.GetNamespace(), secret.GetName())
53-
}
54-
5551
ref := utils.GetGeneratedSecretRef(secret)
56-
// logrus.Infof("generatedSecretsRefs: %s in %s with uid %s", ref.Name, ref.Namespace, ref.UID)
5752

5853
r.Recorder.Eventf(&generatedSecret, corev1.EventTypeNormal, "Created secret", "Created a new secret in namespace '%s'", secret.GetNamespace())
5954
generatedSecretsRefs = append(generatedSecretsRefs, ref)

0 commit comments

Comments
 (0)