RFC: Refactor ConfigBuilder as GlobalOpts #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce helper path_to_string() to avoid using unwrap(). Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
Rename ConfigBuilder as GlobalOpts and moves it into options.rs, to follow the runc man pages. Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
Move runc commandline related constants into options.rs, so options.rs hosts all commandline parsing related code. And util.rs only hosts utilities. Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
Add a unit test case for GlobalOpts. Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
jiangliu
force-pushed
the
globalotps
branch
2 times, most recently
from
b67b6ce to
d170d62
Compare
Burning1020
pushed a commit
to Burning1020/rust-extensions
that referenced
this pull request
May 15, 2024
sandbox: use args from sandboxer instead of os
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ConfigBuilder as GlobalOpts to follow the runc man pages, and move all commandline parsing related code into options.rs.