resolver: replace standard http client to go-retryablehttp #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
power-more
force-pushed
the
zhaoshang/retry
branch
2 times, most recently
from
478729b
to
9dcce02
Compare
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 28.49% 28.42% -0.08%
==========================================
Files 17 17
Lines 1516 1520 +4
==========================================
Hits 432 432
- Misses 1020 1024 +4
Partials 64 64
Continue to review full report at Codecov.
|
power-more
force-pushed
the
zhaoshang/retry
branch
from
9dcce02
to
30288f2
Compare
|
Could you please help to rebase the PR? |
power-more
force-pushed
the
zhaoshang/retry
branch
from
5bf1264
to
14f02e9
Compare
done |
|
Thanks for the contribution, how about also replacing all |
power-more
force-pushed
the
zhaoshang/retry
branch
from
14f02e9
to
403e1d5
Compare
Previously, our snapshot will download the image (nydus blob) through the go standard http client, if the http download fails and does not do a retry. Now we retry for defaultRetryMax = 4 times. Fixes: containerd#54 Signed-off-by: zhaoshang <zhaoshangsjtu@linux.alibaba.com>
Signed-off-by: zhaoshang <zhaoshangsjtu@linux.alibaba.com>
Signed-off-by: zhaoshang <zhaoshangsjtu@linux.alibaba.com>
power-more
force-pushed
the
zhaoshang/retry
branch
from
403e1d5
to
438a892
Compare
imeoer
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our snapshot will download the image through the go standard http
client, if the http download fails and does not do a retry. Now we retry
for defaultRetryMax = 4 times.
Fixes: #54
Signed-off-by: zhaoshang zhaoshangsjtu@linux.alibaba.com