Fix broken TestImageInspectDifferentValidReferencesForTheSameImage #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
cc @AkihiroSuda Tagging @manugupt1 Review at your convenience. |
AkihiroSuda
reviewed
Oct 2, 2024
apostasie
force-pushed
the
urgent-fix-CI-bustage
branch
from
061a0d9
to
f40cc41
Compare
apostasie
commented
Oct 2, 2024
| @@ -71,16 +70,12 @@ func TestImageInspectSimpleCases(t *testing.T) { | |||
| func TestImageInspectDifferentValidReferencesForTheSameImage(t *testing.T) { | |||
| nerdtest.Setup() | |||
|
|
|||
| platform := runtime.GOOS + "/" + runtime.GOARCH | |||
There was a problem hiding this comment.
Earlier version of this test was using linux/amd64, because it was hardcoding the sha.
When I rewrote the test a few weeks ago, I removed the static sha and replaced by a lookup, allowing to use whatever platform - though I did not remove the platform mechanism itself for some reason.
It is unnecesary.
apostasie
force-pushed
the
urgent-fix-CI-bustage
branch
from
f40cc41
to
839f957
Compare
|
Could you update the commit message to explain why |
|
CI is green-ish (Docker failure is unrelated and will get fixed in #3464). |
As of 10/01/2024, busybox latest tag (1.37.0) is no longer the same thing as stable (1.36.1). It is unclear if that was made on purpose, or a problem with Docker publication process. Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Doing now. |
apostasie
force-pushed
the
urgent-fix-CI-bustage
branch
from
839f957
to
c661d16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3479
Reviewers: since the official
busyboxis a moving target, and has just shifted under our feet, I replaced it with a copy underapostasie/busybox.This is a short term fix so that the CI does not stay bust - but I do not like the idea of having images in my personal account.
(Part of) the current intent of this test was apparently to test variants of image names only available on the hub.
To get rid of my images here, here are our options: