Skip to content

exec:support to set custom log path #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ningmingxiao
Copy link
Contributor

@ningmingxiao ningmingxiao commented Jun 11, 2025

I create a pr containerd/containerd#11862 to fix containerd/containerd#8972
I want to specify runc log to custom path when exec .

@ningmingxiao ningmingxiao force-pushed the custom_args branch 5 times, most recently from 4646899 to 43fa230 Compare June 11, 2025 04:58
@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Jun 11, 2025

ping @fuweid @AkihiroSuda @mikebrow can you review this pr thanks?

@ningmingxiao ningmingxiao force-pushed the custom_args branch 3 times, most recently from 3b92e61 to be762e7 Compare June 11, 2025 05:53
@ningmingxiao ningmingxiao force-pushed the custom_args branch 9 times, most recently from 1e7ee71 to 8e276f3 Compare June 11, 2025 09:57
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ningmingxiao
Copy link
Contributor Author

thank you

Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log.json of a container may grow to burst the tmpfs of /run, if a k8s user configure an exec liveness probe of a non exist executable file name.
3 participants