Enable checkpoint/restore auto deduplication of memory images #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 21.40% 25.34% +3.93%
==========================================
Files 7 7
Lines 724 726 +2
==========================================
+ Hits 155 184 +29
+ Misses 528 474 -54
- Partials 41 68 +27 ☔ View full report in Codecov by Sentry. |
austinvazquez
commented
Oct 29, 2023
| defer cancel() | ||
|
|
||
| okRunc := &Runc{ | ||
| Command: "/bin/true", |
There was a problem hiding this comment.
I also tried /bin/echo thinking I could validate the command by having it returned in output for a better assertion; however, runOrError only returns output as error when non-zero exit code.
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
add-checkpoint-args
branch
from
fd99ee4
to
aa7c06c
Compare
austinvazquez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #73
Description
This PR adds
runc checkpoint --auto-dedup <id>andrunc restore --auto-dedup <id>support.Signed-off-by: Austin Vazquez macedonv@amazon.com