Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Defer git updates #188

Open
viceice opened this issue Nov 15, 2021 · 9 comments
Open

git: Defer git updates #188

viceice opened this issue Nov 15, 2021 · 9 comments
Assignees
Labels
priority-2-important User-visible bugs or very important features status:ready Ready to start implementation tool/git type:feature Feature (new functionality)

Comments

@viceice
Copy link
Member

viceice commented Nov 15, 2021

We should defer git updates for a few days to allow binaries to have been published after the git tag was pushed.

@viceice viceice added the type:feature Feature (new functionality) label Nov 15, 2021
@viceice
Copy link
Member Author

viceice commented Nov 16, 2021

@rarkins
Copy link
Member

rarkins commented Nov 16, 2021

Does this mean we should ideally have a different datasource for git?

And in the meantime would stabilityDays work?

@viceice
Copy link
Member Author

viceice commented Nov 16, 2021

yes, otherwise it looks like we have newer git than really installed :(

@viceice
Copy link
Member Author

viceice commented Nov 17, 2021

API:

> curl -s "https://api.launchpad.net/1.0/~git-core/+archive/ubuntu/ppa?ws.op=getPublishedBinaries&binary_name=git&distro_arch_series=https://api.launchpad.net/1.0/ubuntu/focal/amd64&exact_match=true" | jq
{
  "start": 0,
  "total_size": 20,
  "entries": [
    {
      "self_link": "https://api.launchpad.net/1.0/~git-core/+archive/ubuntu/ppa/+binarypub/165350179",
      "resource_type_link": "https://api.launchpad.net/1.0/#binary_package_publishing_history",
      "display_name": "git 1:2.33.1-0ppa1~ubuntu20.04.1 in focal amd64",
      "component_name": "main",
      "section_name": "vcs",
      "source_package_name": "git",
      "source_package_version": "1:2.33.1-0ppa1~ubuntu20.04.1",
      "distro_arch_series_link": "https://api.launchpad.net/1.0/ubuntu/focal/amd64",
      "phased_update_percentage": null,
      "date_published": "2021-10-13T05:29:17.542343+00:00",
      "scheduled_deletion_date": null,
      "status": "Published",
      "pocket": "Release",
      "creator_link": null,
      "date_created": "2021-10-13T05:22:33.273007+00:00",
      "date_superseded": null,
      "date_made_pending": null,
      "date_removed": null,
      "archive_link": "https://api.launchpad.net/1.0/~git-core/+archive/ubuntu/ppa",
      "copied_from_archive_link": "https://api.launchpad.net/1.0/~git-core/+archive/ubuntu/candidate",
      "removed_by_link": null,
      "removal_comment": null,
      "binary_package_name": "git",
      "binary_package_version": "1:2.33.1-0ppa1~ubuntu20.04.1",
      "build_link": "https://api.launchpad.net/1.0/~git-core/+archive/ubuntu/candidate/+build/22272443",
      "architecture_specific": true,
      "priority_name": "OPTIONAL",
      "http_etag": "\"d65771c5a02b94881e8c87ade665f58138a350e1-c1917320571695eae290166f27196ed376811122\""
    },
    {
      "self_link": "https://api.launchpad.net/1.0/~git-core/+archive/ubuntu/ppa/+binarypub/163366084",
      "resource_type_link": "https://api.launchpad.net/1.0/#binary_package_publishing_history",
      "display_name": "git 1:2.33.0-0ppa1~ubuntu20.04.1 in focal amd64",
      "component_name": "main",
      "section_name": "vcs",
      "source_package_name": "git",
      "source_package_version": "1:2.33.0-0ppa1~ubuntu20.04.1",
      "distro_arch_series_link": "https://api.launchpad.net/1.0/ubuntu/focal/amd64",
      "phased_update_percentage": null,
      "date_published": "2021-08-17T00:39:24.560445+00:00",
      "scheduled_deletion_date": "2021-10-14T05:29:35.867679+00:00",
      "status": "Superseded",
      "pocket": "Release",
      "creator_link": null,
      "date_created": "2021-08-17T00:37:55.994101+00:00",
      "date_superseded": "2021-10-13T05:29:35.867679+00:00",
      "date_made_pending": "2021-10-13T05:29:35.867679+00:00",
      "date_removed": "2021-10-14T06:29:10.210658+00:00",
      "archive_link": "https://api.launchpad.net/1.0/~git-core/+archive/ubuntu/ppa",
      "copied_from_archive_link": "https://api.launchpad.net/1.0/~git-core/+archive/ubuntu/candidate",
      "removed_by_link": null,
      "removal_comment": null,
      "binary_package_name": "git",
      "binary_package_version": "1:2.33.0-0ppa1~ubuntu20.04.1",
      "build_link": "https://api.launchpad.net/1.0/~git-core/+archive/ubuntu/candidate/+build/21986727",
      "architecture_specific": true,
      "priority_name": "OPTIONAL",
      "http_etag": "\"1af2467f150f500efcc3c3642468acaafd986d4a-e90867e793b4e88928e80b34e3b0f9090c512c00\""
    },
    ...
  ]
}

@viceice
Copy link
Member Author

viceice commented Nov 17, 2021

@viceice
Copy link
Member Author

viceice commented Nov 17, 2021

paging seems to be 75 by default

{
  "total_size": 277,
  "start": 0,
  "next_collection_link": "https://api.launchpad.net/1.0/%7Egit-core/+archive/ubuntu/ppa?binary_name=git&distro_arch_series=https%3A%2F%2Fapi.launchpad.net%2F1.0%2Fubuntu%2Ffocal%2Famd64&ws.op=getPublishedBinaries&ws.size=75&memo=75&ws.start=75",
  "entries": [
    ...
  ]
}

@viceice
Copy link
Member Author

viceice commented Nov 18, 2021

it seems we should defer for ~3d, as launchpad rerelease was yesterday, so three days later

@viceice
Copy link
Member Author

viceice commented Nov 18, 2021

we also nered to override scope to fix 😕

@viceice viceice added priority-2-important User-visible bugs or very important features status:ready Ready to start implementation labels Jan 24, 2022
@viceice
Copy link
Member Author

viceice commented Feb 17, 2023

maybe we should pre-build git ourselves.

https://github.com/niko-dunixi/git-openssl-shellscript

@viceice viceice changed the title Defer git updates git: Defer git updates Jan 29, 2024
@viceice viceice self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2-important User-visible bugs or very important features status:ready Ready to start implementation tool/git type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants