Add GRPC ControllerModifyVolumeTopology for KEP-5381 #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iltyty
changed the title
|
It will be great if you can also update the KEP and describe how this new PRC will be used in Kubernetes. |
gnufied
reviewed
Jun 25, 2025
| // parameters it intends to modify. SPs MUST NOT modify volumes based | ||
| // on the absence of keys, only keys that are specified should result | ||
| // in modifications to the volume. | ||
| map<string, string> mutable_parameters = 3; |
There was a problem hiding this comment.
If we are modifying topology, why will the request not contain newer accessibility_requirements ?
There was a problem hiding this comment.
We wanted SPs to determine the volume topologies according to the volume type and/or other information. Also, adding this field will result in several issues. E.g., we need to decide the priority between this field and the one in CreateVolume.
ok, will update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it:
This PR adds a new GRPC ControllerModifyVolumeTopology to support KEP #5381.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is an alternative for PR #592.
Does this PR introduce an API-breaking change?: