Skip to content

Commit f3133c6

Browse files
committed
Address review comments
1 parent 843742f commit f3133c6

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

csi.proto

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -991,7 +991,8 @@ message ControllerServiceCapability {
991991
// ListVolumesResponse.entry.published_nodes field
992992
LIST_VOLUMES_PUBLISHED_NODES = 10;
993993

994-
// Indicates the SP supports controller level volume condition.
994+
// Indicates that the Controller service can report volume
995+
// conditions.
995996
// An SP MAY implement `VolumeCondition` in only the Controller
996997
// Plugin, only the Node Plugin, or both.
997998
// If `VolumeCondition` is implemented in both the Controller and
@@ -1364,7 +1365,7 @@ message VolumeUsage {
13641365
Unit unit = 4;
13651366
}
13661367

1367-
// VolumeCondition represents the current condition of a volume
1368+
// VolumeCondition represents the current condition of a volume.
13681369
message VolumeCondition {
13691370
option (alpha_message) = true;
13701371

@@ -1399,7 +1400,7 @@ message NodeServiceCapability {
13991400
GET_VOLUME_STATS = 2;
14001401
// See VolumeExpansion for details.
14011402
EXPAND_VOLUME = 3;
1402-
// Indicates the SP supports node level volume condition.
1403+
// Indicates that the Node service can report volume conditions.
14031404
// An SP MAY implement `VolumeCondition` in only the Node
14041405
// Plugin, only the Controller Plugin, or both.
14051406
// If `VolumeCondition` is implemented in both the Node and

lib/go/csi/csi.pb.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1548,7 +1548,9 @@ message ControllerGetVolumeResponse {
15481548

15491549
##### ControllerGetVolume Errors
15501550

1551-
If the plugin is unable to complete the ControllerGetVolume call successfully, it MUST return a non-ok gRPC code in the gRPC status. If the conditions defined below are encountered, the plugin MUST return the specified gRPC error code. The CO MUST implement the specified error recovery behavior when it encounters the gRPC error code.
1551+
If the plugin is unable to complete the ControllerGetVolume call successfully, it MUST return a non-ok gRPC code in the gRPC status.
1552+
If the conditions defined below are encountered, the plugin MUST return the specified gRPC error code.
1553+
The CO MUST implement the specified error recovery behavior when it encounters the gRPC error code.
15521554

15531555
| Condition | gRPC Code | Description | Recovery Behavior |
15541556
|-----------|-----------|-------------|-------------------|
@@ -1646,7 +1648,8 @@ message ControllerServiceCapability {
16461648
// ListVolumesResponse.entry.published_nodes field
16471649
LIST_VOLUMES_PUBLISHED_NODES = 10;
16481650
1649-
// Indicates the SP supports controller level volume condition.
1651+
// Indicates that the Controller service can report volume
1652+
// conditions.
16501653
// An SP MAY implement `VolumeCondition` in only the Controller
16511654
// Plugin, only the Node Plugin, or both.
16521655
// If `VolumeCondition` is implemented in both the Controller and
@@ -2365,7 +2368,7 @@ message VolumeUsage {
23652368
Unit unit = 4;
23662369
}
23672370
2368-
// VolumeCondition represents the current condition of a volume
2371+
// VolumeCondition represents the current condition of a volume.
23692372
message VolumeCondition {
23702373
option (alpha_message) = true;
23712374
@@ -2419,7 +2422,7 @@ message NodeServiceCapability {
24192422
GET_VOLUME_STATS = 2;
24202423
// See VolumeExpansion for details.
24212424
EXPAND_VOLUME = 3;
2422-
// Indicates the SP supports node level volume condition.
2425+
// Indicates that the Node service can report volume conditions.
24232426
// An SP MAY implement `VolumeCondition` in only the Node
24242427
// Plugin, only the Controller Plugin, or both.
24252428
// If `VolumeCondition` is implemented in both the Node and

0 commit comments

Comments
 (0)