Skip to content

Commit ca8e8d7

Browse files
committed
Restrict the wording of volume_mount_group
and specify that all node publish and node stage rpc calls MUST use same volume_mount_group values.
1 parent 7dc32e3 commit ca8e8d7

File tree

3 files changed

+309
-261
lines changed

3 files changed

+309
-261
lines changed

csi.proto

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1373,12 +1373,11 @@ message NodePublishVolumeRequest {
13731373
// manner, unless otherwise modified by a workload, that they are
13741374
// both readable and writable by said mount group identifier.
13751375
//
1376-
// If Plugin does not support NodePublishVolume with different
1377-
// volume_mount_group than the one used during NodeStageVolume
1378-
// then Plugin MAY return FAILED_PRECONDITION error.
1379-
// Similarly if SP does not support NodePublishVolume of same volume
1380-
// on same node but with different volume_mount_group it MAY return
1381-
// FAILED_PRECONDITION error.
1376+
// If Plugin has STAGE_UNSTAGE_VOLUME capability then value
1377+
// specified here MUST be same as volume_mount_group specified
1378+
// during NodeStageVolume call. When node-publishing same volume
1379+
// multiple times on same node - all NodePublishVolume calls MUST
1380+
// specify same value of volume_mount_group.
13821381
// This is an OPTIONAL field.
13831382
string volume_mount_group = 9;
13841383
}
@@ -1612,7 +1611,7 @@ message NodeExpandVolumeRequest {
16121611
// Secrets required by plugin to complete node expand volume request.
16131612
// This field is OPTIONAL. Refer to the `Secrets Requirements`
16141613
// section on how to use this field.
1615-
map<string, string> secrets = 6
1614+
map<string, string> secrets = 6
16161615
[(csi_secret) = true, (alpha_field) = true];
16171616
}
16181617

0 commit comments

Comments
 (0)