Skip to content

Commit 0c4a56c

Browse files
authored
Merge pull request owncloud#820 from owncloud/release_3.5.2
Release 3.5.2
2 parents dece1ec + 21dfb82 commit 0c4a56c

File tree

10 files changed

+54
-43
lines changed

10 files changed

+54
-43
lines changed

Changelog.md

+8-12
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,17 @@
1+
## 3.5.2 (December 2016)
2+
- New options available for instant uploads. Select what type of media you want to upload
3+
- Stream Photo items from iCloud. Now you can upload your photos even if they are not downloaded into your device
4+
- New menu option to clean all your successful uploads
5+
- Updated user agent
6+
- Bug fixing
7+
- Please, notice that this will be the latest version with support for iOS 8
8+
19
## 3.5.1 (September 2016)
210
- iOS10, Xcode8 and Swift3 Support
311
- Updated app icon
412
- Bug fixing
513

614
## 3.5.0 (August 2016)
7-
815
- Create and edit text files within the app
916
- Clear cache option so that you may delete your downloaded files
1017
- New menu per account to quick access to your account options
@@ -16,8 +23,6 @@
1623
- Added more languages
1724
- Bug fixing
1825

19-
20-
2126
## 3.4.9 (May 2016)
2227
- Sort by date or alphabetically
2328
- Remote thumbnails, images and videos
@@ -35,9 +40,7 @@
3540
- ownCloud 9 server version support
3641
- Minor bugs fixed
3742

38-
3943
## 3.4.6 (December 2015)
40-
4144
- Share privately with users or groups in your server
4245
- Set folder as favorite so that it's content is always downloaded and updated
4346
- Download a folder
@@ -46,7 +49,6 @@
4649
- Fixed an error on the video preview
4750
- Fixed error that requested credentials although having logged in previously
4851

49-
5052
## 3.4.5 (October 2015)
5153
- New share interface, adding support to share with password protect and expiration time
5254
- iOS9 compatibility issues
@@ -65,21 +67,15 @@
6567
## 3.4.1 (March 2015)
6668
- Share link, share your files with password enforced
6769
- Get the app ready for oc 8.1
68-
6970
- Bugs fixed
7071
+ Open in your files on another apps
7172
+ Preview large pdf files
7273

73-
7474
## 3.4.0 (20 March 2015)
75-
7675
- Document provider extension: access to your ownCloud files from other iOS apps
7776
- Instant uploads: enable this option and your new images will be uploaded automatically to your ownCloud account
78-
7977
- Bug fixed: several bug fixes and improvements
8078
- 64-bit support
8179

82-
8380
## 3.3.3 (20 February 2015)
84-
8581
- Prepare the app for ownCloud 8

OC Share Sheet/Info.plist

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<key>CFBundlePackageType</key>
1818
<string>XPC!</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>3.5.1</string>
20+
<string>3.5.2</string>
2121
<key>CFBundleSignature</key>
2222
<string>????</string>
2323
<key>CFBundleVersion</key>

Owncloud iOs Client.xcodeproj/project.pbxproj

+8-8
Original file line numberDiff line numberDiff line change
@@ -5307,7 +5307,7 @@
53075307
CLANG_ENABLE_MODULES = YES;
53085308
CLANG_ENABLE_OBJC_ARC = YES;
53095309
CODE_SIGN_ENTITLEMENTS = "Owncloud iOs Client/Owncloud iOs Client.entitlements";
5310-
CODE_SIGN_IDENTITY = "";
5310+
CODE_SIGN_IDENTITY = "iPhone Developer";
53115311
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
53125312
CODE_SIGN_RESOURCE_RULES_PATH = "";
53135313
DEFINES_MODULE = YES;
@@ -5359,7 +5359,7 @@
53595359
CLANG_ENABLE_MODULES = YES;
53605360
CLANG_ENABLE_OBJC_ARC = YES;
53615361
CODE_SIGN_ENTITLEMENTS = "Owncloud iOs Client/Owncloud iOs Client.entitlements";
5362-
CODE_SIGN_IDENTITY = "";
5362+
CODE_SIGN_IDENTITY = "iPhone Developer";
53635363
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
53645364
CODE_SIGN_RESOURCE_RULES_PATH = "";
53655365
DEFINES_MODULE = YES;
@@ -5468,7 +5468,7 @@
54685468
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
54695469
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
54705470
CODE_SIGN_ENTITLEMENTS = "OC Share Sheet/OC Share Sheet.entitlements";
5471-
CODE_SIGN_IDENTITY = "";
5471+
CODE_SIGN_IDENTITY = "iPhone Developer";
54725472
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
54735473
ENABLE_BITCODE = NO;
54745474
GCC_PREFIX_HEADER = "Owncloud iOs Client/Owncloud iOs Client-Prefix.pch";
@@ -5515,7 +5515,7 @@
55155515
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
55165516
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
55175517
CODE_SIGN_ENTITLEMENTS = "OC Share Sheet/OC Share Sheet.entitlements";
5518-
CODE_SIGN_IDENTITY = "";
5518+
CODE_SIGN_IDENTITY = "iPhone Developer";
55195519
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
55205520
ENABLE_BITCODE = NO;
55215521
ENABLE_NS_ASSERTIONS = NO;
@@ -5564,7 +5564,7 @@
55645564
CLANG_WARN_UNREACHABLE_CODE = YES;
55655565
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
55665566
CODE_SIGN_ENTITLEMENTS = ownCloudExtApp/ownCloudExtApp.entitlements;
5567-
CODE_SIGN_IDENTITY = "";
5567+
CODE_SIGN_IDENTITY = "iPhone Developer";
55685568
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
55695569
DEFINES_MODULE = YES;
55705570
ENABLE_BITCODE = NO;
@@ -5627,7 +5627,7 @@
56275627
CLANG_WARN_UNREACHABLE_CODE = YES;
56285628
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
56295629
CODE_SIGN_ENTITLEMENTS = ownCloudExtApp/ownCloudExtApp.entitlements;
5630-
CODE_SIGN_IDENTITY = "";
5630+
CODE_SIGN_IDENTITY = "iPhone Developer";
56315631
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
56325632
DEFINES_MODULE = YES;
56335633
ENABLE_BITCODE = NO;
@@ -5686,7 +5686,7 @@
56865686
CLANG_WARN_UNREACHABLE_CODE = YES;
56875687
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
56885688
CODE_SIGN_ENTITLEMENTS = ownCloudExtAppFileProvider/ownCloudExtAppFileProvider.entitlements;
5689-
CODE_SIGN_IDENTITY = "";
5689+
CODE_SIGN_IDENTITY = "iPhone Developer";
56905690
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
56915691
DEFINES_MODULE = YES;
56925692
ENABLE_BITCODE = NO;
@@ -5743,7 +5743,7 @@
57435743
CLANG_WARN_UNREACHABLE_CODE = YES;
57445744
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
57455745
CODE_SIGN_ENTITLEMENTS = ownCloudExtAppFileProvider/ownCloudExtAppFileProvider.entitlements;
5746-
CODE_SIGN_IDENTITY = "";
5746+
CODE_SIGN_IDENTITY = "iPhone Developer";
57475747
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
57485748
DEFINES_MODULE = YES;
57495749
ENABLE_BITCODE = NO;

Owncloud iOs Client/Login/Login/LoginViewController.m

+29-15
Original file line numberDiff line numberDiff line change
@@ -1585,12 +1585,17 @@ - (void)textFieldDidEndEditing:(UITextField *)textField {
15851585
NSString *urlWithoutUserPassword = [self stripUsernameAndPassword:self.urlTextField.text];
15861586
self.auxUrlForReloadTable = [self stripIndexPhpOrAppsFilesFromUrl:urlWithoutUserPassword];
15871587
} else {
1588-
//This is when we deleted the last account and go to the login screen
1588+
//This is when we deleted the last account and go to the login screen and when edit credentials in settings view
15891589
self.urlTextField = [[UITextField alloc]initWithFrame:self.urlFrame];
15901590
self.urlTextField.text = self.auxUrlForReloadTable;
15911591
textField = self.urlTextField;
15921592
}
15931593

1594+
if(self.usernameTextField.text == nil) {
1595+
self.usernameTextField = [[UITextField alloc]initWithFrame:self.userAndPasswordFrame];
1596+
self.usernameTextField.text = self.auxUsernameForReloadTable;
1597+
}
1598+
15941599
self.auxUsernameForReloadTable = self.usernameTextField.text;
15951600
self.auxPasswordForReloadTable = self.passwordTextField.text;
15961601

@@ -1672,6 +1677,10 @@ -(void) isConnectionToTheServerByUrlInOtherThread {
16721677
isCheckingTheServerRightNow = YES;
16731678
isConnectionToServer = NO;
16741679

1680+
//Reset the url of redirected server at this point
1681+
AppDelegate *app = (AppDelegate*)[[UIApplication sharedApplication] delegate];
1682+
app.urlServerRedirected = nil;
1683+
16751684
[[CheckAccessToServer sharedManager] isConnectionToTheServerByUrl:[self getUrlToCheck]];
16761685
}
16771686

@@ -1980,39 +1989,42 @@ - (void) checkIfServerAutentificationIsNormalFromURL {
19801989
});
19811990
} failureRequest:^(NSHTTPURLResponse *response, NSError *error, NSString *redirectedServer) {
19821991

1983-
BOOL isInvalid = NO;
1992+
BOOL isInvalid = YES;
1993+
1994+
NSString *authenticationHeader = @"Www-Authenticate";
1995+
NSString *outhAuthentication = @"bearer";
1996+
NSString *basicAuthentication = @"basic";
19841997

19851998
if (!k_is_sso_active) {
1986-
//Get header related with autentication type
1987-
NSString *autenticationType = [[response allHeaderFields] valueForKey:@"Www-Authenticate"];
1988-
1989-
if (autenticationType) {
1990-
//Autentication type basic
1991-
if ([autenticationType hasPrefix:@"Basic"]) {
1992-
isInvalid = NO;
1993-
} else if ([autenticationType hasPrefix:@"Bearer"]) {
1999+
if (response.statusCode == kOCErrorServerUnauthorized) {
2000+
//Get header related with autentication type
2001+
NSString *autenticationType = [[response allHeaderFields] valueForKey:authenticationHeader];
2002+
2003+
if ((autenticationType) && ([autenticationType.lowercaseString hasPrefix:outhAuthentication])) {
19942004
//Autentication type oauth
19952005
if (k_is_oauth_active) {
19962006
//Check if is activate oauth
19972007
isInvalid = NO;
19982008
} else {
19992009
isInvalid = YES;
20002010
}
2011+
} else if ((autenticationType) && ([autenticationType.lowercaseString hasPrefix:basicAuthentication])) {
2012+
isInvalid = NO;
20012013
} else {
2002-
//Unknown autentication type
2003-
isInvalid = YES;
2014+
//For the moment we have to mantain this value as valid because when we work with
2015+
//some Redirected Server our library lost the Wwww-Authenticate header
2016+
isInvalid = NO;
20042017
}
2005-
} else {
2006-
//The server not return a Www-Authenticate header
2007-
isInvalid = YES;
20082018
}
2019+
20092020
} else {
20102021
//If sso_active the check does not fail
20112022
//As we are receiving a SAML error from SAML server, we forced the flag to accept this connection
20122023
isInvalid = NO;
20132024
isLoginButtonEnabled = YES;
20142025
}
20152026

2027+
20162028
//Update the interface depend of if isInvalid or not
20172029
if (isInvalid) {
20182030
hasInvalidAuth = YES;
@@ -2208,6 +2220,8 @@ -(void)createUserAndDataInTheSystemWithRequest:(NSArray *)items andCode:(NSInteg
22082220
userDto.password = passwordUTF8;
22092221
userDto.ssl = isHttps;
22102222
userDto.activeaccount = YES;
2223+
//Take into account that this global property can be stored bab value
2224+
//For that we reset this property when the system check the server in LoginViewController class
22112225
userDto.urlRedirected = app.urlServerRedirected;
22122226

22132227
[ManageUsersDB insertUser:userDto];

Owncloud iOs Client/Owncloud iOs Client-Info.plist

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
<key>CFBundlePackageType</key>
6262
<string>APPL</string>
6363
<key>CFBundleShortVersionString</key>
64-
<string>3.5.1</string>
64+
<string>3.5.2</string>
6565
<key>CFBundleSignature</key>
6666
<string>????</string>
6767
<key>CFBundleURLTypes</key>

Owncloud iOs Client/Tabs/FileTab/FilesViewController.m

+2-1
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,8 @@ - (void)viewWillAppear:(BOOL)animated
303303

304304
if(!([currentUser.username isEqualToString:_mUser.username] &&
305305
[currentUser.password isEqualToString:_mUser.password] &&
306-
[currentUser.url isEqualToString:_mUser.url])) {
306+
[currentUser.url isEqualToString:_mUser.url] &&
307+
currentUser.idUser == _mUser.idUser)) {
307308
//We are changing of user
308309
//Show the file list in the correct place
309310
[_tableView setContentOffset:CGPointMake(0,0) animated:animated];

THIRD_PARTY.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ The third party software included and used by this project is:
116116
Original license document included at ExternalLibreries/VFR Pdf Reader/LICENSE.
117117
See https://github.com/vfr/Reader
118118

119-
* ownCloud iOS Library v 2.0.1
120-
Copyright (c) 2014 ownCloud Inc. (http://www.owncloud.org/)
119+
* ownCloud iOS Library v 2.0.2
120+
Copyright (c) 2016, ownCloud GmbH. (http://www.owncloud.org/)
121121
Licensed under MIT License.
122122
Placed at OCCommunicationLib
123123
Original license document included at OCCommunicationLib/LICENSE.

ownCloudExtApp/Info.plist

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<key>CFBundlePackageType</key>
1818
<string>XPC!</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>3.5.1</string>
20+
<string>3.5.2</string>
2121
<key>CFBundleSignature</key>
2222
<string>????</string>
2323
<key>CFBundleVersion</key>

ownCloudExtAppFileProvider/Info.plist

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<key>CFBundlePackageType</key>
1818
<string>XPC!</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>3.5.1</string>
20+
<string>3.5.2</string>
2121
<key>CFBundleSignature</key>
2222
<string>????</string>
2323
<key>CFBundleVersion</key>

0 commit comments

Comments
 (0)