You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Errors indicating a client fault (like INVALID_ARGUMENT) must not result in spans being marked as errors. This makes sense: for instance, user errors should not trigger alerts.
This is actually a duplicate of #122. There was a proposed fix in #144. We originally had some concerns about accepting that change, but we're now revisiting and think that is indeed the right way to proceed.
Since it's a duplicate, I'm closing it, Please follow the other issue for updates.
Per Otel spec for gRPC only errors indicating server fault (like
INTERNAL
) must result in the span being marked as errors.https://opentelemetry.io/docs/specs/semconv/rpc/grpc/#grpc-status
Errors indicating a client fault (like
INVALID_ARGUMENT
) must not result in spans being marked as errors. This makes sense: for instance, user errors should not trigger alerts.Otelconnect incorrectly reports all failed RPCs as errors here:
https://github.com/connectrpc/otelconnect-go/blob/main/interceptor.go#L357-L368
The text was updated successfully, but these errors were encountered: