Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server spans incorrectly marked as errors for client faults #157

Closed
nichtverstehen opened this issue Dec 6, 2023 · 2 comments
Closed

Server spans incorrectly marked as errors for client faults #157

nichtverstehen opened this issue Dec 6, 2023 · 2 comments

Comments

@nichtverstehen
Copy link

Per Otel spec for gRPC only errors indicating server fault (like INTERNAL) must result in the span being marked as errors.
https://opentelemetry.io/docs/specs/semconv/rpc/grpc/#grpc-status

Errors indicating a client fault (like INVALID_ARGUMENT) must not result in spans being marked as errors. This makes sense: for instance, user errors should not trigger alerts.

Otelconnect incorrectly reports all failed RPCs as errors here:
https://github.com/connectrpc/otelconnect-go/blob/main/interceptor.go#L357-L368

@jhump
Copy link
Member

jhump commented Dec 7, 2023

@nichtverstehen, thanks for this report. We will look into a fix.

@jhump
Copy link
Member

jhump commented Dec 8, 2023

This is actually a duplicate of #122. There was a proposed fix in #144. We originally had some concerns about accepting that change, but we're now revisiting and think that is indeed the right way to proceed.

Since it's a duplicate, I'm closing it, Please follow the other issue for updates.

@jhump jhump closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants