-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental plugin #178
Conversation
@vctqs1 After experimenting with this plugin, we've decided to remove it to simplify the offerings. Obviously you can fork and maintain the plugin yourself, but in order to maintain the API for v5 of react-query, we're going to keep to the original plugin as the primary means of generating helpers. |
## What's Changed * Remove experimental plugin by @paul-sachs in #178 * Add ESM wrapper to avoid dual package hazard by @timostamm in #180 * Fix missing implicit types by @mckelveygreg in #211 ## New Contributors * @mckelveygreg made their first contribution in #211 **Full Changelog**: v0.5.1...v0.5.2
@paul-sachs hi, sorry, but Could I publish this experiment plugin in my own? Is it |
@vctqs1 yes, you can most certainly publish your own plugin and package. Feel free to form the repo. |
@paul-sachs thank you 👍🏻 |
@paul-sachs ohm thank you, im currently working on Tanstack v4. Because of some breaking changes of onError/onSuccess in v5, it's make me afraid to upgrade version for now I also noticed about tree-shaking problem in current source. Yeah, but glad to heard that your team're gonna to do an enhancement on this proposal also. Please help me know and loop on any update on this proposal, and progressing. Thank you |
@tanstack/react-query
v5 is introducing some major changes to their types and also introduce suspense specific APIs (useSuspenseQuery, useSuspenseInfiniteQuery, and useSuspenseQueries). These APIs are pretty easy to integrate with the original plugin (non-react specific) but would need an additional two APIs generated for every service method. This starts to create a lot of noise with our auto-complete options:As an example, if we have a service method called
say
, we now must generateuseSayQuery
,useSayInfiniteQuery
,useSayMutation
,useSaySuspenseQuery
, anduseSaySuspenseInfiniteQuery
. This is increasingly making a lot of noise when just trying to use thesay
method from a service. This is much worse with larger service method names.In keeping with best practices (limiting the number of ways to do a single thing), we've decided to remove this plugin from the repo.