Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all interfaces to start with "I" #28

Closed
gbirchmeier opened this issue Jan 17, 2012 · 2 comments · Fixed by #148
Closed

Rename all interfaces to start with "I" #28

gbirchmeier opened this issue Jan 17, 2012 · 2 comments · Fixed by #148

Comments

@gbirchmeier
Copy link
Member

...in accordance with standard C# naming convention.

Existing interface names should be changed to empty sub-interfaces of the new-named interface in order to preserve compilation of existing projects. They should also be deprecated (with the System.Obsolete annotation).

Example: see IAcceptor and it's empty sub-interface Acceptor.
@gbirchmeier
Copy link
Member Author

Will push on this after May release.

@gbirchmeier
Copy link
Member Author

Running list of affected interfaces that I notice while working on other bugs:

  • LogFactory
  • Application
  • Log
  • MessageStore
  • MessageStoreFactory
  • Responder

Related tasks:

  • Rename DD/FieldMapSpec.cs filename to DD/IFieldMapSpec.cs
  • Same for GroupSpec

gbirchmeier added a commit that referenced this issue Nov 26, 2012
@gbirchmeier
issue #28 - rename all interfaces (and their files) to start with "I"
f79bf3d
@gbirchmeier gbirchmeier mentioned this issue Nov 26, 2012
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename interfaces gbirchmeier/quickfixn
1 participant
@gbirchmeier