Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo's use of bash-lib means you can't run the scripts individually #89

Open
izgeri opened this issue Feb 19, 2020 · 4 comments
Open

Repo's use of bash-lib means you can't run the scripts individually #89

izgeri opened this issue Feb 19, 2020 · 4 comments

Comments

@izgeri
Copy link
Contributor

izgeri commented Feb 19, 2020

Expected behavior:

  • I can run any one of the individual scripts, or run them one by one, if I want to

Actual behavior:

  • If I deploy the apps by running ./start, and I try to run just script 7 to recheck the deployments, I get
    $ ./7_verify_authentication.sh 
     ++++++++++++++++++++++++++++++++++++++
    
     Validating that the deployments are functioning as expected.
    
     ++++++++++++++++++++++++++++++++++++++
     Waiting for pods to become available
     ./7_verify_authentication.sh: line 42: bl_retry_constant: command not found
    
     Stopping all port-forwarding
    

Note: there is an open PR in #88 to revise the shebangs in the scripts to enable using a newer version of bash. We should probably also indicate bash v4+ in the README requirements.

@InbalZilberman
Copy link

@hughsaunders is this still a bug?

@eladkug
Copy link
Contributor

eladkug commented Aug 17, 2020

@hughsaunders are we going to fix this?

@izgeri
Copy link
Contributor Author

izgeri commented Aug 17, 2020

@eladkug fyi @hughsaunders is off on PTO this week, so it will be a week before he can respond.

@eladkug
Copy link
Contributor

eladkug commented Oct 11, 2020

@hughsaunders can you please update ?

@eladkug eladkug closed this as completed Nov 18, 2020
@eladkug eladkug added this to the Archive milestone Nov 18, 2020
@eladkug eladkug reopened this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants