You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Discussion started here #43 (comment) (refactor node.level to an unsigned integer value or panic/err if methods that expect a non-negative int receive a negative on; find out which approach is safer/faster/more reasonable).
Also, clarify if and how we want to deal with overflows (also in case of uint(32/64) if we go with unsigned values).
The text was updated successfully, but these errors were encountered:
Good read! I did some small tests, and it seems like uint32and uint64 have the same underflow issue as described in the article. Given this, I think it might be safer to panic/err if methods that expect a non-negative int receive a negative one.
Discussion started here #43 (comment) (refactor
node.level
to an unsigned integer value or panic/err if methods that expect a non-negative int receive a negative on; find out which approach is safer/faster/more reasonable).Also, clarify if and how we want to deal with overflows (also in case of uint(32/64) if we go with unsigned values).
The text was updated successfully, but these errors were encountered: