🚫 blocked: Artifact e2e - refactor and add dimension #3074
+130
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: merge from main
Cerchie
commented
Nov 24, 2025
| // Clean up: delete the uploaded artifact using the correct name | ||
| await artifactsView.deleteFlinkArtifact(uploadedArtifactName); | ||
| await artifactsView.clickSelectKafkaClusterAsFlinkDatabase(); | ||
| await page.keyboard.type("azure"); |
Contributor
Author
There was a problem hiding this comment.
We can't associate compute pools with clusters even under the same env, we should match on provider/region. But how can we be sure there's even a match if we're looking dynamically?
Also we can't search for cluster via cluster label (has to be the name) so we're stuck if we go down that route.
I think a dedicated test env, or maybe even org, could start helping out a lot.
Cerchie
commented
Nov 24, 2025
| const uploadedArtifactName = await artifactsView.uploadFlinkArtifact(electronApp, artifactPath); | ||
|
|
||
| await expect(artifactsView.artifacts.filter({ hasText: uploadedArtifactName })).toHaveCount(1); | ||
| const entrypoints = [ |
Contributor
Author
There was a problem hiding this comment.
some refactoring for readability on the way here
Cerchie
changed the title
Cerchie
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Click-testing instructions
Optional: Any additional details or context that should be provided?
Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Release notes