chore(E2E): add dedicated topic fixture for creation/deletion
#3020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airlock-confluentinc
bot
force-pushed
the
djs/topic-fixture
branch
from
73f9cf0 to
147ada5
Compare
shouples
commented
Nov 24, 2025
Comment on lines
+90
to
+94
| /** | ||
| * Set up a topic based on the {@linkcode topicConfig} option and return the associated topic | ||
| * `name` for tests to reference. | ||
| */ | ||
| topic: string; |
Contributor
Author
There was a problem hiding this comment.
I've debated making this return { name: string } but I don't know what else we would need to return in here in the future, and changing the fixture to topicName felt weird from the perspective of illustrating what the fixture does (setup- and teardown-wise)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We had a few test suites that implemented their own logic to make sure a Kafka topic was created before the actual-test logic ran (and similarly implemented their own logic to delete said topic afterward).
This PR adds a new
topicfixture to consolidate creation and deletion logic into one place. No functional changes, nor explicit behavioral changes to affected tests, but is required for #3021Closes #3014
Optional: Any additional details or context that should be provided?
@requires-topictag to make it easier to run these affected tests, and may extend the pattern in follow-up branches for things like@requires-schema. (I don't think we'll need@requires-kafka-cluster/@requires-schema-registry/@requires-flink-compute-pollanytime soon, but can revisit later.)Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Release notes