open statements as editable (untitled) documents instead of read-only
#2873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the read-only limitation of Flink statement documents, allowing users to open them as editable documents instead. When clicking a Flink statement in the view, users now get an editable untitled document rather than a read-only one, enabling direct editing and resubmission.
Key changes:
- Removed the
FlinkStatementDocumentProviderclass and its read-only document scheme - Updated
viewStatementSqlCommandto create editableuntitleddocuments with proper metadata - Simplified URI scheme handling to only support
fileanduntitledschemes
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/documentProviders/flinkStatement.ts | Completely removed the read-only document provider class |
| src/documentProviders/flinkStatement.test.ts | Removed corresponding test file |
| src/commands/flinkStatements.ts | Updated to create editable untitled documents instead of read-only ones |
| src/commands/flinkStatements.test.ts | Updated tests to verify untitled document creation |
| src/extension.ts | Removed FlinkStatementDocumentProvider from registered providers |
| src/flinkSql/flinkLanguageClientManager.ts | Simplified URI scheme validation to only allow file/untitled |
| src/flinkSql/flinkLanguageClientManager.test.ts | Updated tests to reflect new URI scheme restrictions |
| src/documentMetadataManager.ts | Removed flinkstatement scheme from supported schemes |
| src/documentMetadataManager.test.ts | Restructured tests and removed flinkstatement-specific test cases |
| CHANGELOG.md | Added user-facing description of the new editable statement behavior |
This comment has been minimized.
This comment has been minimized.
…Flink Statements view instead of the read-only version
…d of read-only scheme" handling
…space; update tests
airlock-confluentinc
bot
force-pushed
the
djs/untitled-flinksql
branch
from
a5fbf8b to
d36a625
Compare
Analysis Details0 Issues
Coverage and Duplications
Project ID: vscode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR removes the read-only limitation of the document that appears when clicking a statement item from the Flink Statements view in favor of an editable (
untitled-scheme) document. This means instead of having to save a read-only statement document or copy and paste it into a new document, users can edit and resubmit (as a new statement) on the fly.edit-statement.mov
Optional: Click-testing instructions
Optional: Any additional details or context that should be provided?
src/documentMetadataManager.test.tswas reorganized to follow thefile->class->method->testhierarchy, so line changes are inflatedPull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Release notes