Final improvements before releasing 3.0 #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astubbs
force-pushed
the
road-to-three-point-o
branch
8 times, most recently
from
21db743 to
ae4a318
Compare
parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/ParallelConsumerOptions.java
Outdated
Show resolved
Hide resolved
Some tests now aggresively check for progress between success tests, failing if no progress has been made after some attempts. Cached info for mail boxes for thread safety. Config options have been removed where not needed, and max threads renamed to max concurrency, to fit better with the Vert.x module. Fixes confluentinc#38 Back pressure system broken - max uncommitted message settings not honoured
In the future, we may introduce immediate commit modes, see confluentinc#40: Feature: Transactional mode for individual consume producer loop instead of periodic batch
…d anymore This collection is no longer shared between threads, because of the new MailBox and CountingCRLinkedList.
… it is per partition This massively improves the odds of not hitting the limit. However, the new back pressure system being developed still needs to be added, as it is possible to be hit.
As this is only calculated at the end of a batch cycle, and not continuously, it may be too late, and offsets have to be dropped. But it’s relatively simple and get’s us a lot of the way to the continuous (correct) solution). Bitset test and fixes Test failed messages that are blocking the partition can always retry, test pessimistic partition blocking (buffer of available payload space)
astubbs
force-pushed
the
road-to-three-point-o
branch
from
ae4a318 to
19a9d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52