Add connectorname and Task ID for the threads #1507
+46
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
skaushikcflt
reviewed
May 8, 2025
| @@ -75,6 +77,8 @@ public TableMonitorThread(DatabaseDialect dialect, | |||
| this.blacklist = blacklist; | |||
| this.tables = new AtomicReference<>(); | |||
| this.time = time; | |||
|
|
|||
| this.setName(connectorName + "-" + taskId + "-TableMonitorThread") | |||
There was a problem hiding this comment.
who is the caller of this? I don't see where exactly are we creating a thread, if we are using executorService, it would be better to set the thread name over there.
There was a problem hiding this comment.
We are calling for creating new thread here. We are not using any executorService in the JDBC Connector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan