Skip to content

Add example listing committed offsets and lag#909

Merged
Magnus Edenhill (edenhill) merged 2 commits into
masterfrom
offex
Jul 8, 2020
Merged

Add example listing committed offsets and lag#909
Magnus Edenhill (edenhill) merged 2 commits into
masterfrom
offex

Conversation

@edenhill
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@rnpridgeon Ryan P (rnpridgeon) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by this example. It seems to demonstrate how one might sidestep limitations in the admin client. Does this belong in an FAQ instead? Ideally this functionality would come to through the admin client and then an example of such.

Comment thread examples/list_offsets.py
import confluent_kafka


if len(sys.argv) < 4:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use argparse like the existing examples?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it simple.
4 examples use sys.argv, 6 use argparse.

@edenhill
Copy link
Copy Markdown
Contributor Author

how one might sidestep limitations in the admin client.

That's a much bigger task, including adding new APIs to librdkafka and the Python client, so until then we need to explain how to go about getting this information using what is available, since we get this question quite frequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants