Skip to content

Fix failure to use fastavro when no Avro reader schema is given #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

woodlee
Copy link
Contributor

@woodlee woodlee commented Apr 13, 2020

When MessageSerializer is initialized without a reader_schema, the to_json method call on the None value at L178 results in an exception. Since this happens in a broad try/except block that captures all exceptions, it was leading to a silent failure to use the fastavro library in such cases. This is a quick fix for that.

@ghost
Copy link

ghost commented Apr 13, 2020

It looks like @woodlee hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@woodlee
Copy link
Contributor Author

woodlee commented Apr 13, 2020

[clabot:check]

@ghost
Copy link

ghost commented Apr 13, 2020

@confluentinc It looks like @woodlee just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@woodlee
Copy link
Contributor Author

woodlee commented Apr 20, 2020

Thanks @mparry , I had not realized this was s duplicate of nos. #694 and #773 . Closing this.

@woodlee woodlee closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant