Skip to content

Add ability to set subject name strategies #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

mpyatishev
Copy link

Unfortunately, PR #502 stalled for a long time. So I decided to make my humble attempt to solve this problem.
With this patch, you can set the Subject Name Strategy in CachedSchemaRegistryClient , for example:

client = CachedSchemaRegistryClient({
  'url': 'http://localhost',
  'key.subject.name.strategy': "TopicRecordNameStrategy",
  'value.subject.name.strategy': "TopicRecordNameStrategy",
})

@ghost
Copy link

ghost commented Jan 13, 2020

It looks like @mpyatishev hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

1 similar comment
@ghost
Copy link

ghost commented Jan 13, 2020

It looks like @mpyatishev hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@mpyatishev
Copy link
Author

[clabot:check]

@ghost
Copy link

ghost commented Jan 13, 2020

@confluentinc It looks like @mpyatishev just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@mpyatishev mpyatishev requested a review from rnpridgeon January 15, 2020 06:19
@mpyatishev mpyatishev requested a review from edenhill January 24, 2020 05:36
@mpyatishev
Copy link
Author

Can anybody review this PR?

@mpyatishev
Copy link
Author

How can I restart the AppVeyor build if the problem is not in my code?

@mpyatishev
Copy link
Author

@rnpridgeon , can you review my fixes for your changes request?

@agates4
Copy link

agates4 commented Mar 12, 2020

@mpyatishev thank you very much for this PR. I hope that this gets approved and merged. This is a problem that is blocking our org.

@agates4
Copy link

agates4 commented Mar 12, 2020

@rnpridgeon please review

@agates4
Copy link

agates4 commented Mar 12, 2020

@edenhill please review

@edenhill
Copy link
Contributor

I believe @rnpridgeon 's PR #787 will add support for this in some form.

@mpyatishev
Copy link
Author

It seems like I should close this PR in favor of #787

@mpyatishev mpyatishev closed this Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants