V1.0 deprecations #498
Merged
V1.0 deprecations #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
suggested changes
Dec 3, 2018
edenhill
suggested changes
Dec 4, 2018
rnpridgeon
force-pushed
the
v1.0-deprecations
branch
from
7977e88 to
2c0e90a
Compare
edenhill
suggested changes
Dec 4, 2018
rnpridgeon
force-pushed
the
v1.0-deprecations
branch
from
2c0e90a to
fd45851
Compare
edenhill
suggested changes
Dec 4, 2018
rnpridgeon
force-pushed
the
v1.0-deprecations
branch
from
fdf7cf3 to
eb10d8b
Compare
edenhill
suggested changes
Dec 5, 2018
examples/confluent_cloud.py
Outdated
| print("Consumer error: {}".format(msg.error())) | ||
| continue | ||
|
|
||
| print('consumed: {0}'.format(msg.value())) |
There was a problem hiding this comment.
The positional {0} is not really needed, {} is fine and more consistent with other code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note two remaining
default.topic.configare already handled in #440