Skip to content

OpenSSL version bump to 1.0.2o #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2018
Merged

OpenSSL version bump to 1.0.2o #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1ceccb
OpenSSL version bump to 1.0.2o
rnpridgeon Jun 25, 2018
b31680a
fix ordering
rnpridgeon Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions tools/RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,20 @@ replace as necessary with your version or remove `rc..` suffix for the
final release.


## 1. Update in-source versions
## 1. Update OpenSSL version if necessary

As of v0.11.4 OpenSSL is packaged with the python client. It's important
that the OpenSSL version is kept up to date with the latest release.

Update `OPENSSL_VERSION` in `tools/build-openssl.sh` with the latest 1.0.x version
as documented at [openssl.org](https://www.openssl.org/source/)

Commit this change with a commit-message mentioning the version bump:

$ git commit -m "OpenSSL version bump to 1.0.2o" tools/build-openssl.sh


## 2. Update in-source versions

There are a number of source files that needs to be updated with the
new version number, the easiest way to find these is to search for the
Expand All @@ -43,15 +56,15 @@ Commit these changes with a commit-message containing the version:
$ git commit -m "Version v0.11.4rc1" confluent_kafka/src/confluent_kafka.c docs/conf.py setup.py


## 2. Create a tag
## 3. Create a tag

The tag should be created right after the commit and be named the same as
the version.

$ git tag v0.11.4rc1


## 3. Push tag and commits
## 4. Push tag and commits

Perform a dry-run push first to make sure the correct branch and only our tag
is pushed.
Expand All @@ -66,13 +79,13 @@ An alternative is to push branch and tags separately:
$ git push --dry-run --tags origin v0.11.4rc1


## 4. Wait for CI builds
## 5. Wait for CI builds

Monitor travis-ci builds by looking atthe *tag* build at
[travis-ci]https://travis-ci.org/confluentinc/confluent-kafka-python


## 5. Download build artifacts from S3
## 6. Download build artifacts from S3

*Note*: You will need set up your AWS credentials in `~/.aws/credentials` to
gain access to the S3 bucket.
Expand All @@ -87,7 +100,7 @@ The artifacts will be downloaded to `dl-<tag>/`.



## 6. Verify packages
## 7. Verify packages

Create a new virtualenv:

Expand All @@ -106,7 +119,7 @@ and librdkafka versions:
py: ('0.11.4', 721920) c: ('0.11.4-RC1', 722121)


## 7. Upload packages to PyPi
## 8. Upload packages to PyPi

To upload binary packages to test.pypi.org, use:

Expand All @@ -127,7 +140,7 @@ Upload source packages to the proper pypi.org (WARNING!):
$ python setup.py sdist upload


## 8. Verify installation from PyPi
## 9. Verify installation from PyPi

In the same virtualenv as created above:

Expand All @@ -151,7 +164,7 @@ Verify that the package works and prints the expected version:



## 9. Create github release
## 10. Create github release

If this was the final release, go to
[github releases](https://github.com/confluentinc/confluent-kafka-python/releases)
Expand Down
2 changes: 1 addition & 1 deletion tools/build-openssl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

# NOTE: Keep this updated to make sure we always build the latest
# version of OpenSSL in the 1.0 release train.
OPENSSL_VERSION=1.0.2l
OPENSSL_VERSION=1.0.2o

PREFIX=$1
if [[ -z $PREFIX ]]; then
Expand Down