Add missing dependency on googleapis-common-protos when using protobufs #1881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the Schema Registry with Protobufs, `confluent_kafka/schema_registry/protobuf.py` imports from the `google.type` package, which is part of the googleapis-common-protos library, but the library is not specified as a dependency. This adds that library as a dependency to make sure it is installed, so users won't hit an issue trying to import to Protobuf schema registry code in case they don't have googleapis-common-protos installed.
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When using the Schema Registry with Protobufs,
confluent_kafka/schema_registry/protobuf.pyimports from thegoogle.typepackage, which is part of the googleapis-common-protos library, but the library is not specified as a dependency.This adds that library as a dependency to make sure it is installed, so users won't hit an issue trying to import to Protobuf schema registry code in case they don't have googleapis-common-protos installed.
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups