PR comments

Author: pranavrth

src/confluent_kafka/admin/__init__.py

@@ -109,7 +109,7 @@ class AdminClient (_AdminClientImpl):
     Requires broker version v0.11.0.0 or later.
     """
 
-    def __init__(self, conf, logger=None):
+    def __init__(self, conf, **kwargs):
         """
         Create a new AdminClient using the provided configuration dictionary.
 
@@ -120,9 +120,7 @@ def __init__(self, conf, logger=None):
         :param dict conf: Configuration properties. At a minimum ``bootstrap.servers`` **should** be set\n"
         :param Logger logger: Optional Logger instance to use as a custom log messages handler.
         """
-        if logger is not None:
-            conf['logger'] = logger
-        super(AdminClient, self).__init__(conf)
+        super(AdminClient, self).__init__(conf, **kwargs)
 
     @staticmethod
     def _make_topics_result(f, futmap):

tests/test_log.py

@@ -25,7 +25,7 @@ def _setup_string_buffer_logger(name):
     handler = logging.StreamHandler(stringBuffer)
     handler.setFormatter(logging.Formatter('%(name)s Logger | %(message)s'))
     logger.addHandler(handler)
-    return stringBuffer,logger
+    return stringBuffer, logger
 
 
 def test_logging_consumer():