From 72b0a29983547b938eb83de162053f14e52515fb Mon Sep 17 00:00:00 2001 From: Miles Todzo Date: Fri, 4 Dec 2020 09:28:16 -0800 Subject: [PATCH] fix nits --- run_bin.go | 4 ++-- run_bin_test.go | 4 ---- test_bins/read_stdin.sh | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/run_bin.go b/run_bin.go index e44ab44..a9db8e3 100644 --- a/run_bin.go +++ b/run_bin.go @@ -101,7 +101,7 @@ func PostExec(cmdFuncs ...CmdFunc) CoverageCollectorOption { } // RunBinary runs the instrumented binary at binPath with env environment variables, executing only the test with mainTestName with the specified args. -func (c *CoverageCollector) RunBinary(binPath string, mainTestName string, env []string, args []string, options ... CoverageCollectorOption) (output string, exitCode int, err error) { +func (c *CoverageCollector) RunBinary(binPath string, mainTestName string, env []string, args []string, options ...CoverageCollectorOption) (output string, exitCode int, err error) { if !c.setupFinished { panic("RunBinary called before Setup") } @@ -238,4 +238,4 @@ func removeTempCoverageFile(name string) { func haveTestsToRun(output string) bool { prefix := "testing: warning: no tests to run" return !strings.HasPrefix(output, prefix) -} \ No newline at end of file +} diff --git a/run_bin_test.go b/run_bin_test.go index e9563f3..594e4d1 100644 --- a/run_bin_test.go +++ b/run_bin_test.go @@ -595,8 +595,6 @@ func TestCoverageCollector_RunBinary(t *testing.T) { args: args{ binPath: "./test_bins/read_stdin.sh", mainTestName: "", - env: nil, - args: nil, }, fields: fields{ MergedCoverageFilename: "temp_coverage.out", @@ -612,8 +610,6 @@ func TestCoverageCollector_RunBinary(t *testing.T) { args: args{ binPath: "./test_bins/read_stdin.sh", mainTestName: "", - env: nil, - args: nil, }, fields: fields{ MergedCoverageFilename: "temp_coverage.out", diff --git a/test_bins/read_stdin.sh b/test_bins/read_stdin.sh index 719d5bf..32c9136 100755 --- a/test_bins/read_stdin.sh +++ b/test_bins/read_stdin.sh @@ -5,4 +5,4 @@ do done < /dev/stdin echo START_BINCOVER_METADATA echo "{\"cover_mode\":\"\",\"exit_code\":1}" -echo END_BINCOVER_METADATA \ No newline at end of file +echo END_BINCOVER_METADATA