fix nits

confluentinc · Dec 4, 2020 · 72b0a29 · 72b0a29
1 parent b0c1991
commit 72b0a29
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/run_bin.go b/run_bin.go
@@ -101,7 +101,7 @@ func PostExec(cmdFuncs ...CmdFunc) CoverageCollectorOption {
 }
 
 // RunBinary runs the instrumented binary at binPath with env environment variables, executing only the test with mainTestName with the specified args.
-func (c *CoverageCollector) RunBinary(binPath string, mainTestName string, env []string, args []string, options ... CoverageCollectorOption) (output string, exitCode int, err error) {
+func (c *CoverageCollector) RunBinary(binPath string, mainTestName string, env []string, args []string, options ...CoverageCollectorOption) (output string, exitCode int, err error) {
 	if !c.setupFinished {
 		panic("RunBinary called before Setup")
 	}
@@ -238,4 +238,4 @@ func removeTempCoverageFile(name string) {
 func haveTestsToRun(output string) bool {
 	prefix := "testing: warning: no tests to run"
 	return !strings.HasPrefix(output, prefix)
-}
+}
diff --git a/run_bin_test.go b/run_bin_test.go
@@ -595,8 +595,6 @@ func TestCoverageCollector_RunBinary(t *testing.T) {
 			args: args{
 				binPath:      "./test_bins/read_stdin.sh",
 				mainTestName: "",
-				env:          nil,
-				args:         nil,
 			},
 			fields: fields{
 				MergedCoverageFilename: "temp_coverage.out",
@@ -612,8 +610,6 @@ func TestCoverageCollector_RunBinary(t *testing.T) {
 			args: args{
 				binPath:      "./test_bins/read_stdin.sh",
 				mainTestName: "",
-				env:          nil,
-				args:         nil,
 			},
 			fields: fields{
 				MergedCoverageFilename: "temp_coverage.out",

diff --git a/test_bins/read_stdin.sh b/test_bins/read_stdin.sh
@@ -5,4 +5,4 @@ do
 done < /dev/stdin
 echo START_BINCOVER_METADATA
 echo "{\"cover_mode\":\"\",\"exit_code\":1}"
-echo END_BINCOVER_METADATA
+echo END_BINCOVER_METADATA