Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configcat-react deps is installing an incompatible configcat-common dependency #49

Closed
dcefram opened this issue Jan 16, 2024 · 2 comments · Fixed by #48
Closed

configcat-react deps is installing an incompatible configcat-common dependency #49

dcefram opened this issue Jan 16, 2024 · 2 comments · Fixed by #48
Labels
bug Something isn't working

Comments

@dcefram
Copy link

dcefram commented Jan 16, 2024

Describe the bug

When doing a fresh installation of configcat-react, it would install a peer deps of configcat-common. The problem is that the peer deps is not compatible.

configcat-react version 4.2.0 requires configcat-common version ^9.1.0.

This installs version 9.2.0 which is apparently not compatible with configcat-react version 4.2.0.

To reproduce

  1. Do a fresh install npm i configcat-react
  2. Try to import configcat-react in your react project
  3. It would throw errors related to configcat-react trying to import something that is not exported anymore.

Expected behavior

No errors should show when importing configcat-react

Screenshots

share-rmrz-ph 2024-01-16 at 23 49 56@2x

SDK version

configcat-react version 4.2.0

SDK configuration

Please copy paste the client initialization code snippet, so we can see how you are using the SDK.

Logs

N/A

Language/Framework version

N/A

Platform

MacOS

Note that the workaround is to explicitly install configcat-common version ~9.1.0 in my own package.json.

@dcefram dcefram added the bug Something isn't working label Jan 16, 2024
@adams85
Copy link
Contributor

adams85 commented Jan 16, 2024

Hi @dcefram,

it looks like we've been bitten by the ^ version references of NPM.

Because of the ^ reference, configcat-common v9.2.0 is resolved instead of v9.1.0 and the former is incompatible with configcat-react v4.2.0 indeed as configcat-common v9.2.0 comes with a minor public API breaking change (where public means public to configcat-react but not public to the consumers of configcat-react). Yet this breaks configcat-react v4.2.0 and earlier.

After discussing the issue, we plan to solve the issue with fixed version references.

Sorry for the inconvience, the new version with the fix will be available soon.

@adams85 adams85 linked a pull request Jan 16, 2024 that will close this issue
4 tasks
@adams85
Copy link
Contributor

adams85 commented Jan 16, 2024

FYI, configcat-react v4.3.0 has been released and should fix the issue. Please let us know if you still experience problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants