Conversation
…s and moved shared enums
This reverts commit cb9fc88.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
nthmost-orkes
left a comment
There was a problem hiding this comment.
This looks great except for one little thing -- CONDUCTOR_PROXY_HEADERS has several tests around it while CONDUCTOR_PROXY has zero (apparently?).
We should have at least one test around this variable to protect it, i.e. make it more obvious when we might be about to do a release that changes something about how the SDK is operated.
Sure, just missed that. Thanks for notice -- done |
nthmost-orkes
left a comment
There was a problem hiding this comment.
Nice, thank you for the updates!
Changes:
Updated sync API client to enable proxy configuration
Updated config to make it possible to set proxy via env vars
Added proxy section to README.md
Added examples with proxy configuration