Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 4ad59d6

Browse files
committedOct 27, 2023
Tweak comments
1 parent b1f21aa commit 4ad59d6

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed
 

‎tests/test_conda_lock.py

+8-4
Original file line numberDiff line numberDiff line change
@@ -2306,11 +2306,13 @@ def test_cli_version(capsys: "pytest.CaptureFixture[str]"):
23062306
def test_pip_finds_recent_manylinux_wheels(
23072307
monkeypatch: "pytest.MonkeyPatch", lightgbm_environment: Path, conda_exe: str
23082308
):
2309-
"""Ensure that we find a pre-built manylinux wheel for lightgbm.
2309+
"""Ensure that we find a manylinux wheel with glibc > 2.17 for lightgbm.
23102310
2311-
If not, installation would trigger a build of lightgbm from source. If this test
2312-
fails, it likely means that MANYLINUX_TAGS in `conda_lock/pypi_solver.py` is out of
2313-
date.
2311+
See https://github.com/conda/conda-lock/issues/517 for more context.
2312+
2313+
If not found, installation would trigger a build of lightgbm from source.
2314+
If this test fails, it likely means that MANYLINUX_TAGS in
2315+
`conda_lock/pypi_solver.py` is out of date.
23142316
"""
23152317
monkeypatch.chdir(lightgbm_environment.parent)
23162318
run_lock([lightgbm_environment], conda_exe=conda_exe, platforms=["linux-64"])
@@ -2324,4 +2326,6 @@ def test_pip_finds_recent_manylinux_wheels(
23242326
assert manylinux_match, "No match found for manylinux version in {lightgbm_dep.url}"
23252327

23262328
manylinux_version = [int(each) for each in manylinux_match.groups()]
2329+
# Make sure the manylinux wheel was built with glibc > 2.17 as a
2330+
# non-regression test for #517
23272331
assert manylinux_version > [2, 17]

0 commit comments

Comments
 (0)
Please sign in to comment.