Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta.yaml #35

Closed
wants to merge 2 commits into from
Closed

Update meta.yaml #35

wants to merge 2 commits into from

Conversation

till-m
Copy link
Member

@till-m till-m commented Dec 23, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@till-m
Copy link
Member Author

till-m commented Dec 23, 2024

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [26]
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12466384455. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12466391921. Examine the logs at this URL for more detail.

@till-m
Copy link
Member Author

till-m commented Dec 27, 2024

@conda-forge/core I'm at a loss at what is the best way to handle this. This package is purely python code (so noarch: python is appropriate), but when installing under python 3.13 with most package managers, I needed to explicitly specify the scipy version otherwise the install fails (see. bayesian-optimization/BayesianOptimization#534). Functionality-wise, any version of scipy should work, so specifying the version is purely to make the install possible.

@h-vetinari
Copy link
Member

This shouldn't be necessary in conda-forge. We have no 3.13 builds for anything before scipy 1.14, so the solver has no other option than to take 1.14

@till-m
Copy link
Member Author

till-m commented Dec 27, 2024

perfect, thanks!

@till-m till-m closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants