Skip to content

Answer to exercise 1-4 ch.5 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2015

Conversation

ryblovAV
Copy link
Contributor

Hi @axel22
Pls see my answers

@volatile
var dummy: Any = _

def buildObjects(count:Int) = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: you could use ScalaMeter here.

@axel22
Copy link
Member

axel22 commented Oct 5, 2015

LGTM

The Cellular Automaton example could be further optimized, but it looks correct to me!

axel22 added a commit that referenced this pull request Oct 5, 2015
Answer to exercise 1-4 ch.5
@axel22 axel22 merged commit ac69f89 into concurrent-programming-in-scala:master Oct 5, 2015
@axel22
Copy link
Member

axel22 commented Oct 5, 2015

Hm, it looks like this broke the build, due to some issues with JavaFX.

https://travis-ci.org/concurrent-programming-in-scala/learning-examples/builds/83789552

@ryblovAV
Copy link
Contributor Author

ryblovAV commented Oct 6, 2015

Hi @axel22,
I added sbt dependency for JavaFX 8, but travis.yml uses oraclejdk7.
Could you use JDK 8 ?

@axel22
Copy link
Member

axel22 commented Oct 7, 2015

Scala 2.11 provides only experimental support for JDK 8, and is mainly targeting JDK 7. I feel a bit anxious about changing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants