Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab connector assigns name as username #7

Closed
pfijalki opened this issue May 3, 2019 · 3 comments · Fixed by #12 or concourse/concourse#5925
Closed

gitlab connector assigns name as username #7

pfijalki opened this issue May 3, 2019 · 3 comments · Fixed by #12 or concourse/concourse#5925

Comments

@pfijalki
Copy link

pfijalki commented May 3, 2019

In
https://github.com/concourse/dex/blob/master/connector/gitlab/gitlab.go:187

one can find

	ident.Name = name
	ident.Username = name
        ident.Email = user.Email

probably should be

ident.Username  = user.Username

which seems to be incorrect assingment

@vito
Copy link
Member

vito commented Aug 1, 2019

@pivotal-jwinters Looks like this is something changed in our fork, do you think it should be changed? (Is it too late? Is this going to break people using GitLab integration?)

@jwntrs
Copy link

jwntrs commented Aug 1, 2019

@vito @pfijalki yeah it should probably be changed to user.Username

@tuapuikia
Copy link

Now I know why it failed when I use gitlab username instead of gitlab user full name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants