Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] MSBuildToolchain doesn't honor compiler.runtime_type #17099

Open
SpaceIm opened this issue Oct 1, 2024 · 0 comments · May be fixed by #17100
Open

[bug] MSBuildToolchain doesn't honor compiler.runtime_type #17099

SpaceIm opened this issue Oct 1, 2024 · 0 comments · May be fixed by #17100
Assignees

Comments

@SpaceIm
Copy link
Contributor

SpaceIm commented Oct 1, 2024

Describe the bug

MSBuildToolchain doesn't seem to honor compiler.runtime_type from profile, and instead completely relies on build_type to determine RuntimeLibrary to inject in props file.

So for example if someone has a profile like this:

[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.version=193
compiler.cppstd=20
compiler.runtime=static
compiler.runtime_type=Release
os=Windows

props file will contain <RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>, while conan user would expect <RuntimeLibrary>MultiThreaded</RuntimeLibrary>.

CMakeToolchain for exemple behaves as expected, so it leads to inconsistency across different packages built with this profile.

How to reproduce it

Issue has been described in conan-io/conan-center-index#25433 with all details.

@SpaceIm SpaceIm linked a pull request Oct 1, 2024 that will close this issue
5 tasks
@memsharded memsharded self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants