tk: add v8.6.13 #22040

valgur · 2023-12-28T18:49:26Z

No description provided.

Ahajha · 2024-01-14T05:55:05Z

I found a few prior works, and it seems that the -ObjC flag is necessary when linking:
https://core.tcl-lang.org/tk/tktview/85f316beb15108ac43b03fa6c8608e31f3ae5f92
indygreg/PyOxidizer#613

I also have the new frameworks as well as the -ObjC flag conditional to the new version. It's possible those are added somewhere between 8.6.10 and 8.6.13, but for our purposes the condition should be fine.

(Will debug v2 tomorrow, unsure what happened here)

Ahajha · 2024-01-14T18:07:23Z

Not sure about the new error. It works on my machine(tm) but I have a newer OS and compiler, so it might be related to that. I've seen some suggestions but they mostly suggested modifying system settings, which doesn't seem like the right solution to me.

Ahajha · 2024-01-18T04:08:30Z

Really struggling to find what the cause of this, the only thread that seems to hint at anything remotely close to this problem is this one which suggests a bug in MacOS Ventura... But that's confusing as it works on my M2 with that OS (if I recall correctly). Not sure what Mac version the CCI runners are using.

This reverts commit 940f874.

valgur · 2024-04-19T08:42:20Z

Oh, wow. Nice job, @Ahajha. Thanks!

Ahajha · 2024-04-19T14:50:50Z

@valgur Just some context, essentially I found a function that does nothing if you pass in NULL. This mirrors a lot of what @jcar87 was saying in the recent protobuf PR about the test package being simple.

The only thing I don't like is that the weird runtime dependency on MacOS won't get caught by this package, maybe we can have it so that it uses the simple test only in CCI, so that at least it's caught locally?

CLAassistant · 2024-07-31T20:11:03Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ valgur
✅ Ahajha
❌ Alex Trotta

Alex Trotta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Ahajha · 2024-08-01T15:51:44Z

Not sure how to fix that... I must have been using another machine, but that's definitely me.

recipes/tk/all/conanfile.py

valgur · 2024-08-01T19:39:49Z

Not sure how to fix that... I must have been using another machine, but that's definitely me.

Force-pushing with the correct name / email should fix this.

This reverts commit 3bc0da0.

conan-center-bot · 2024-09-26T11:58:54Z

Conan v1 pipeline ❌

Failure in build 13 (37829cb2561a6bc914a7e93a7e825415c89c209f):

tk/8.6.13:
CI failed to create some packages (All logs)

Logs for packageID 49ec5528afd464ae0e73a717e8fa8e395916eb42:

[settings]
arch=armv8
build_type=Debug
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=13.0
os=Macos
[options]
tk:shared=False

[...]
      _TkpDisplayWarning in libtk8.6.a(tkMacOSXInit.o)
      _StdinProc in libtk8.6.a(tkMain.o)
      _Prompt in libtk8.6.a(tkMain.o)
  "_Tcl_WriteObj", referenced from:
      _StdinProc in libtk8.6.a(tkMain.o)
      _Prompt in libtk8.6.a(tkMain.o)
      _TkCanvPostscriptCmd in libtk8.6.a(tkCanvPs.o)
  "_Tcl_WrongNumArgs", referenced from:
      _Tk_WmObjCmd in libtk8.6.a(tkMacOSXWm.o)
      _WmAspectCmd in libtk8.6.a(tkMacOSXWm.o)
      _WmAttributesCmd in libtk8.6.a(tkMacOSXWm.o)
      _WmClientCmd in libtk8.6.a(tkMacOSXWm.o)
      _WmColormapwindowsCmd in libtk8.6.a(tkMacOSXWm.o)
      _WmCommandCmd in libtk8.6.a(tkMacOSXWm.o)
      _WmDeiconifyCmd in libtk8.6.a(tkMacOSXWm.o)
      ...
  "_Tcl_ZlibCRC32", referenced from:
      _ReadData in libtk8.6.a(tkImgPNG.o)
      _ReadChunkHeader in libtk8.6.a(tkImgPNG.o)
      _ReadBase64 in libtk8.6.a(tkImgPNG.o)
      _ReadByteArray in libtk8.6.a(tkImgPNG.o)
      _WriteData in libtk8.6.a(tkImgPNG.o)
      _WriteIHDR in libtk8.6.a(tkImgPNG.o)
      _WriteChunk in libtk8.6.a(tkImgPNG.o)
      ...
  "_Tcl_ZlibStreamClose", referenced from:
      _CleanupPNGImage in libtk8.6.a(tkImgPNG.o)
  "_Tcl_ZlibStreamEof", referenced from:
      _DecodePNG in libtk8.6.a(tkImgPNG.o)
      _ReadIDAT in libtk8.6.a(tkImgPNG.o)
  "_Tcl_ZlibStreamGet", referenced from:
      _ReadIDAT in libtk8.6.a(tkImgPNG.o)
      _WriteIDAT in libtk8.6.a(tkImgPNG.o)
  "_Tcl_ZlibStreamInit", referenced from:
      _InitPNGImage in libtk8.6.a(tkImgPNG.o)
  "_Tcl_ZlibStreamPut", referenced from:
      _ReadIDAT in libtk8.6.a(tkImgPNG.o)
      _WriteIDAT in libtk8.6.a(tkImgPNG.o)
ld: symbol(s) not found for architecture arm64e
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [wish] Error 1
WARN: **************************************************
WARN: *** Conan 1 is legacy and on a deprecation path **
WARN: *********** Please upgrade to Conan 2 ************
WARN: **************************************************
tk/8.6.13: ERROR: Package '49ec5528afd464ae0e73a717e8fa8e395916eb42' build failed
tk/8.6.13: WARN: Build folder /Users/jenkins/workspace/prod-v1/bsr@2/102844/bcbdc/.conan/data/tk/8.6.13/_/_/build/49ec5528afd464ae0e73a717e8fa8e395916eb42/build-debug
ERROR: tk/8.6.13: Error in build() method, line 220
	autotools.make()
	ConanException: Error 2 while executing make 'TCL_GENERIC_DIR=/Users/jenkins/workspace/prod-v1/bsr@2/102844/bcbdc/.conan/data/tcl/8.6.13/_/_/package/a60d991f22cb90dbf618e728b0ca8fd8f77d9c42/include' -j8

tk/8.6.10:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 13 (37829cb2561a6bc914a7e93a7e825415c89c209f):

tk/8.6.13:
CI failed to create some packages (All logs)

Logs for packageID bd2d723bcd6b0ed67efe26dca8d26e49a550316e:

[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=17
compiler.libcxx=libc++
compiler.version=13
os=Macos
[options]
*/*:shared=False

[...]
      ...
  "_Tcl_Write", referenced from:
      _WriteToChannel in libtk8.6.a(tkImgGIF.o)
      _WriteData in libtk8.6.a(tkImgPNG.o)
      _FileWritePPM in libtk8.6.a(tkImgPPM.o)
  "_Tcl_WriteChars", referenced from:
      _TkpDisplayWarning in libtk8.6.a(tkMacOSXInit.o)
      _StdinProc in libtk8.6.a(tkMain.o)
      _Prompt in libtk8.6.a(tkMain.o)
  "_Tcl_WriteObj", referenced from:
      _StdinProc in libtk8.6.a(tkMain.o)
      _Prompt in libtk8.6.a(tkMain.o)
      _TkCanvPostscriptCmd in libtk8.6.a(tkCanvPs.o)
  "_Tcl_WrongNumArgs", referenced from:
      _Tk_WmObjCmd in libtk8.6.a(tkMacOSXWm.o)
      _TkUnsupported1ObjCmd in libtk8.6.a(tkMacOSXWm.o)
      _TkMacOSXGetAppPathCmd in libtk8.6.a(tkMacOSXInit.o)
      _TkMacOSXStandardAboutPanelObjCmd in libtk8.6.a(tkMacOSXDialog.o)
      _Tk_MenuObjCmd in libtk8.6.a(tkMenu.o)
      _MenuWidgetObjCmd in libtk8.6.a(tkMenu.o)
      _Tk_GetScrollInfoObj in libtk8.6.a(tkUtil.o)
      ...
  "_Tcl_ZlibCRC32", referenced from:
      _ReadData in libtk8.6.a(tkImgPNG.o)
      _ReadChunkHeader in libtk8.6.a(tkImgPNG.o)
      _EncodePNG in libtk8.6.a(tkImgPNG.o)
      _WriteData in libtk8.6.a(tkImgPNG.o)
  "_Tcl_ZlibStreamClose", referenced from:
      _CleanupPNGImage in libtk8.6.a(tkImgPNG.o)
  "_Tcl_ZlibStreamEof", referenced from:
      _DecodePNG in libtk8.6.a(tkImgPNG.o)
  "_Tcl_ZlibStreamGet", referenced from:
      _DecodePNG in libtk8.6.a(tkImgPNG.o)
      _EncodePNG in libtk8.6.a(tkImgPNG.o)
  "_Tcl_ZlibStreamInit", referenced from:
      _FileMatchPNG in libtk8.6.a(tkImgPNG.o)
      _InitPNGImage in libtk8.6.a(tkImgPNG.o)
  "_Tcl_ZlibStreamPut", referenced from:
      _DecodePNG in libtk8.6.a(tkImgPNG.o)
      _EncodePNG in libtk8.6.a(tkImgPNG.o)
ld: symbol(s) not found for architecture arm64e
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [wish] Error 1

tk/8.6.13: ERROR: 
Package 'bd2d723bcd6b0ed67efe26dca8d26e49a550316e' build failed
tk/8.6.13: WARN: Build folder /Users/jenkins/workspace/prod-v2/bsr@2/91588/bfbce/p/b/tk00fdf236ecd07/b/build-release
ERROR: tk/8.6.13: Error in build() method, line 220
	autotools.make()
	ConanException: Error 2 while executing

tk/8.6.10:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Ahajha · 2024-09-26T12:08:39Z

@valgur I think there was a part of that reverted commit that's still necessary. I'll try to fix the CLA problem.

valgur · 2024-09-26T12:14:13Z

@Ahajha I already overwrote the author and force-pushed that commit, so the CLA issue should be fixed. The CLA check is having issues in all PRs today, it looks like, so it has not updated the status yet.

tk: add v8.6.13

90d9e3f

ghost mentioned this pull request Dec 28, 2023

[service] Potentially conflicting recipes #3571

Closed

prince-chrismc mentioned this pull request Dec 28, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Dec 30, 2023

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

valgur added 2 commits January 3, 2024 15:47

tk: fix Windows patch

896653d

tk: add Quartz to macOS system deps

8119721

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Jan 13, 2024

tk: modernize more & fix build requirements logic for windows non-msvc #19897

Closed

3 tasks

Fix test package on Mac with, add frameworks conditionally

2bcd620

conan-center-bot added the Unexpected Error label Jan 14, 2024

This comment has been minimized.

Sign in to view

Use QuartzCore instead of Quartz

4f75ff5

conan-center-bot removed the Unexpected Error label Jan 14, 2024

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Jan 17, 2024

Bump/tk/all #22391

Closed

3 tasks

Try different test package

940f874

This comment has been minimized.

Sign in to view

Merge branch 'master' into update/tk

cf0567f

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Jan 26, 2024

[tk] Use xorg components, fix MSVC shared build #22549

Merged

3 tasks

Ahajha added 3 commits January 26, 2024 22:34

Try adding automake to build requirements

2c75446

Add ObjC to shared link flags as well

a756e07

Revert "Try different test package"

c60ba06

This reverts commit 940f874.

Ahajha added 4 commits April 16, 2024 18:30

Simplify test package

fa2df83

Restore includes in test package

41a657c

Only simplify tk part of test package

56825e4

Remove whitespace

bf89854

This comment has been minimized.

Sign in to view

Ahajha and others added 2 commits April 17, 2024 09:16

Simplify test package

ea6b639

Merge branch 'master' into update/tk

15863b1

This comment has been minimized.

Sign in to view

conan-center-bot added the Unexpected Error label Apr 18, 2024

This comment has been minimized.

Sign in to view

conan-center-bot removed Unexpected Error Failed labels Apr 18, 2024

This comment has been minimized.

Sign in to view

AbrilRBS self-assigned this May 20, 2024

Ahajha reviewed Aug 1, 2024

View reviewed changes

recipes/tk/all/conanfile.py Outdated Show resolved Hide resolved

Ahajha and others added 2 commits September 26, 2024 14:14

Add MSVC shared build patch from 8.6.13

e3c5981

Merge remote-tracking branch 'upstream/master' into update/tk

7ddfb07

valgur force-pushed the update/tk branch from 8c84d3f to 7ddfb07 Compare September 26, 2024 11:15

tk: revert "Try using unix build system on mac"

1f37873

This reverts commit 3bc0da0.

conan-center-bot added the Failed label Sep 26, 2024

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'upstream/master' into update/tk

37829cb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tk: add v8.6.13 #22040

tk: add v8.6.13 #22040

valgur commented Dec 28, 2023

This comment has been minimized.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Ahajha commented Jan 14, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

Ahajha commented Jan 14, 2024

This comment has been minimized.

Ahajha commented Jan 18, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

valgur commented Apr 19, 2024

Ahajha commented Apr 19, 2024

CLAassistant commented Jul 31, 2024 •

edited

Loading

Ahajha commented Aug 1, 2024

valgur commented Aug 1, 2024 •

edited

Loading

This comment has been minimized.

conan-center-bot commented Sep 26, 2024

Ahajha commented Sep 26, 2024

valgur commented Sep 26, 2024

tk: add v8.6.13 #22040

Are you sure you want to change the base?

tk: add v8.6.13 #22040

Conversation

valgur commented Dec 28, 2023

This comment has been minimized.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Ahajha commented Jan 14, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

Ahajha commented Jan 14, 2024

This comment has been minimized.

Ahajha commented Jan 18, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

valgur commented Apr 19, 2024

Ahajha commented Apr 19, 2024

CLAassistant commented Jul 31, 2024 • edited Loading

Ahajha commented Aug 1, 2024

valgur commented Aug 1, 2024 • edited Loading

This comment has been minimized.

conan-center-bot commented Sep 26, 2024

Conan v1 pipeline ❌

Conan v2 pipeline ❌

Ahajha commented Sep 26, 2024

valgur commented Sep 26, 2024

Ahajha commented Jan 14, 2024 •

edited

Loading

CLAassistant commented Jul 31, 2024 •

edited

Loading

valgur commented Aug 1, 2024 •

edited

Loading