Merge pull request flask-restful#219 from twilio/fix-float-field

Fix fields.Float to output actual floats per JSON spec

Author: skimbrel

flask_restful/fields.py

@@ -249,7 +249,7 @@ class Float(Raw):
 
     def format(self, value):
         try:
-            return repr(float(value))
+            return float(value)
         except ValueError as ve:
             raise MarshallingException(ve)
 

tests/test_api.py

@@ -752,5 +752,21 @@ def get(self):
         self.assertEquals(resp.status_code, 302)
         self.assertEquals(resp.headers['Location'], 'http://localhost/')
 
+    def test_json_float_marshalled(self):
+        app = Flask(__name__)
+        api = flask_restful.Api(app)
+
+        class FooResource(flask_restful.Resource):
+            fields = {'foo': flask_restful.fields.Float}
+            def get(self):
+                return flask_restful.marshal({"foo": 3.0}, self.fields)
+
+        api.add_resource(FooResource, '/api')
+
+        app = app.test_client()
+        resp = app.get('/api')
+        self.assertEquals(resp.status_code, 200)
+        self.assertEquals(resp.data, '{"foo": 3.0}')
+
 if __name__ == '__main__':
     unittest.main()

tests/test_fields.py

@@ -26,12 +26,12 @@ def check_field(expected, field, value):
 
 def test_float():
     values = [
-        ("-3.13", "-3.13"),
-        (str(-3.13), "-3.13"),
-        (3, "3"),
+        ("-3.13", -3.13),
+        (str(-3.13), -3.13),
+        (3, 3.0),
     ]
     for value, expected in values:
-        yield check_field, expected, fields.Arbitrary(), value
+        yield check_field, expected, fields.Float(), value
 
 
 def test_boolean():
@@ -179,7 +179,7 @@ def test_int_decode_error(self):
 
     def test_float(self):
         field = fields.Float()
-        self.assertEquals('3.0', field.output("hey", {'hey': 3.0}))
+        self.assertEquals(3.0, field.output("hey", {'hey': 3.0}))
 
     def test_float_decode_error(self):
         field = fields.Float()