Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Commit 1b92a01

Browse files
Make sure extension URL’s do not end up in the result json
This was changed in Firefox 60. Firefox is now reporting these url’s in originUrl in webRequest
1 parent 956ec7b commit 1b92a01

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

runner-modules/httpEvents/lib/background/TrackHttpEvents.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ const urlForShortTitle = require('../../../../lib/urlForShortTitle');
55

66
const ERROR_SHORT_TITLE_MAX_LENGTH = 64;
77

8+
const filterExtensionUrl = url => (url && /^moz-extension:/.test(url) ? null : url);
9+
810
class TrackHttpEvents {
911
constructor({runResult, browserWebRequest, browserWindowId}) {
1012
this.runResult = runResult;
@@ -69,7 +71,7 @@ class TrackHttpEvents {
6971
parentEvent.setMetaData('frameId', frameId);
7072
parentEvent.setMetaData('tabId', tabId);
7173
parentEvent.setMetaData('type', type);
72-
parentEvent.setMetaData('originUrl', originUrl);
74+
parentEvent.setMetaData('originUrl', filterExtensionUrl(originUrl));
7375
}
7476
catch (err) {
7577
log.error({err, requestId, url}, 'Error during webRequest.onBeforeRequest');

0 commit comments

Comments
 (0)