Skip to content

fix: make usePropagate to return a stable function ref #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2024
Merged

fix: make usePropagate to return a stable function ref #23

merged 3 commits into from
Nov 14, 2024

Conversation

@OEvgeny
Copy link
Contributor

@OEvgeny OEvgeny commented Nov 14, 2024 •
edited
Loading

Changelog

Fixed

  • Fixed usePropagate hook to return a stable function reference across re-renders, in PR #23, by @OEvgeny

Specific changes

  • Added useCallback hook to memoize the propagation function
  • Added test case to verify function reference stability across re-renders
  • Maintained existing propagation-during-render warning behavior

@OEvgeny OEvgeny marked this pull request as ready for review November 14, 2024 20:55
@compulim compulim merged commit a9ee70f into compulim:main Nov 14, 2024
12 checks passed
@OEvgeny OEvgeny deleted the fix/unstable-use-propagate-ref branch November 14, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OEvgeny @compulim