Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two different definitions of PotLike #54

Open
Pet3ris opened this issue Aug 26, 2020 · 0 comments
Open

Two different definitions of PotLike #54

Pet3ris opened this issue Aug 26, 2020 · 0 comments

Comments

@Pet3ris
Copy link
Contributor

Pet3ris commented Aug 26, 2020

Hi There,

DAIInterestRateModelV3 and CDaiDelegate now have two different implementations of the Maker PotLike interface with the same name.

DAIInterestRateModelV3.sol

contract PotLike {
    function chi() external view returns (uint);
    function dsr() external view returns (uint);
    function rho() external view returns (uint);
    function pie(address) external view returns (uint);
    function drip() external returns (uint);
    function join(uint) external;
    function exit(uint) external;
}

CDaiDelegate.sol

interface PotLike {
    function chi() external view returns (uint);
    function pie(address) external view returns (uint);
    function drip() external returns (uint);
    function join(uint) external;
    function exit(uint) external;
}

Generally, there seems to be a practice of renaming old interfaces/contracts using versions to avoid confusion and conflicts within compilation/flattening tools - I wonder if this should be applicable in this instance as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant