Clean-up unusedcode

[llaville]

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

1. Does your submission pass tests?
2. Have you lint your code locally prior to submission?

Goal 1

By running PHP Mess Detector on this repository, I've recently opened a report about unused private method.

Here are original reporting with PHPMD 2.15 (PHAR version)

php -d error_reporting=8191 phpmd.phar src ansi unusedcode

Expected results :

Found 0 violations and 0 errors in 359ms

No mess detected

Current results :

FILE: /shared/backups/forks/symbol-parser/src/Symbol/Loader/FileSymbolLoader.php
--------------------------------------------------------------------------------
 139 | VIOLATION | Avoid unused private methods such as 'filterExistingDir'.


FILE: /shared/backups/forks/symbol-parser/src/Symbol/Loader/PsrSymbolLoader.php
-------------------------------------------------------------------------------
 22  | VIOLATION | Avoid unused local variables such as '$dir'.

Found 2 violations and 0 errors in 691ms

This PR fixed the two violations by upgrading code to compatible PHP 7.4 syntax !

Goal 2

Remove unused imports

This PR add a PHP CS Fixer config file (.php-cs-fixer.dist.php) to detect at least unused imports

With such file content, and by running command

php php-cs-fixer.phar check -v --diff

I got this report

PHP CS Fixer 3.35.1 (ec1ccc2) Freezy Vrooom by Fabien Potencier and Dariusz Ruminski.
PHP runtime: 8.2.16
Loaded config default from "/shared/backups/forks/symbol-parser/.php-cs-fixer.dist.php".
..............................F.F..................................................................                               99 / 99 (100%)
Legend: .-no changes, F-fixed, S-skipped (cached or empty file), I-invalid file syntax (file ignored), E-error
   1) src/Parser/PHP/Strategy/FullQualifiedParameterStrategy.php (no_unused_imports)
      ---------- begin diff ----------
--- /shared/backups/forks/symbol-parser/src/Parser/PHP/Strategy/FullQualifiedParameterStrategy.php
+++ /shared/backups/forks/symbol-parser/src/Parser/PHP/Strategy/FullQualifiedParameterStrategy.php
@@ -5,7 +5,6 @@
 namespace ComposerUnused\SymbolParser\Parser\PHP\Strategy;

 use PhpParser\Node;
-use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Name\FullyQualified;

 final class FullQualifiedParameterStrategy implements StrategyInterface

      ----------- end diff -----------

   2) src/Parser/PHP/SymbolCollectorInterface.php (no_unused_imports)
      ---------- begin diff ----------
--- /shared/backups/forks/symbol-parser/src/Parser/PHP/SymbolCollectorInterface.php
+++ /shared/backups/forks/symbol-parser/src/Parser/PHP/SymbolCollectorInterface.php
@@ -5,7 +5,6 @@
 namespace ComposerUnused\SymbolParser\Parser\PHP;

 use Closure;
-use ComposerUnused\SymbolParser\Symbol\SymbolName;
 use PhpParser\NodeVisitor;

 interface SymbolCollectorInterface extends NodeVisitor

      ----------- end diff -----------


Found 2 of 99 files that can be fixed in 0.319 seconds, 18.633 MB memory used

[llaville]

@icanhazstring I think we should also add the global_namespace_import rule and configure like that :

diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
index 0d5bd29..5b84188 100644
--- a/.php-cs-fixer.dist.php
+++ b/.php-cs-fixer.dist.php
@@ -4,6 +4,7 @@ declare(strict_types=1);

 return (new PhpCsFixer\Config())
     ->setRules([
+        'global_namespace_import' => ['import_classes' => true, 'import_constants' => true, 'import_functions' => true],
         'no_unused_imports' => true,
     ])
     ->setFinder(

That will allows to have code homogeneous with global imports. WDYT about it ?

[icanhazstring]

Looks good. Why not. LGTM