Skip to content

Commit a6c896c

Browse files
gloursndeloof
authored andcommitted
make provider.type attribut required
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
1 parent e07723c commit a6c896c

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

loader/loader_test.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3791,6 +3791,19 @@ services:
37913791
"booleans": []string{"true", "false"},
37923792
},
37933793
})
3794+
3795+
_, err = loadYAML(`
3796+
name: service-provider
3797+
services:
3798+
test:
3799+
provider:
3800+
options:
3801+
bar: zot
3802+
strings: foo
3803+
numbers: 12
3804+
booleans: true
3805+
`)
3806+
assert.Check(t, strings.Contains(err.Error(), "services.test.provider type is required"))
37943807
}
37953808

37963809
func TestImageVolume(t *testing.T) {

schema/compose-spec.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,7 @@
392392
"provider": {
393393
"type": "object",
394394
"description": "Specify a service which will not be manage by Compose directly, and delegate its management to an external provider.",
395+
"required": ["type"],
395396
"properties": {
396397
"type": {
397398
"type": "string",

0 commit comments

Comments
 (0)