From 51c54ebcaf031412d99acf88b1f87db38b9f84e4 Mon Sep 17 00:00:00 2001
From: ArthurDeclercq <Arthur.Declercq@UGent.be>
Date: Thu, 28 Sep 2023 11:24:49 +0200
Subject: [PATCH] moved installer to different github workflow

---
 .github/workflows/test.yml              | 40 -------------------------
 .github/workflows/windows_installer.yml | 31 +++++++++++++++++++
 ms2rescore_innosetup.iss                |  2 +-
 3 files changed, 32 insertions(+), 41 deletions(-)
 create mode 100644 .github/workflows/windows_installer.yml

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 43d02b1e..ae565344 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -42,43 +42,3 @@ jobs:
       - name: Test installation
         run: |
           ms2rescore --help
-  windows-installer:
-    runs-on: windows-latest
-    steps:
-      - uses: actions/checkout@v2
-
-      - uses: actions/setup-python@v2
-        with:
-          python-version: "3.8"
-
-      - name: Install package and dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install . pyinstaller
-      - name: Install Inno Setup
-        uses: crazy-max/ghaction-chocolatey@v1
-        with:
-          args: install innosetup -y --allow-unofficial --force
-
-      - name: Run pyinstaller
-        run: pyinstaller ./ms2rescore.spec --clean --noconfirm
-
-      - name: Test built exe
-        run: dist/ms2rescore/ms2rescore.exe
-
-      - name: Run Inno Setup
-        run: ISCC.exe ./ms2rescore_innosetup.iss /DMyAppVersion=$(ms2rescore -v)
-
-      - name: Upload artifact
-        uses: actions/upload-artifact@v2
-        with:
-          name: dist
-          path: dist/*.exe
-
-      - name: Upload installer to release
-        uses: svenstaro/upload-release-action@v2
-        with:
-          repo_token: ${{ secrets.GITHUB_TOKEN }}
-          tag: ${{ github.ref }}
-          file_glob: true
-          file: dist/*.exe
\ No newline at end of file
diff --git a/.github/workflows/windows_installer.yml b/.github/workflows/windows_installer.yml
new file mode 100644
index 00000000..88683b5a
--- /dev/null
+++ b/.github/workflows/windows_installer.yml
@@ -0,0 +1,31 @@
+on:
+  pull_request:
+    branches:
+    - main
+
+  windows-installer:
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: actions/setup-python@v2
+        with:
+          python-version: "3.8"
+
+      - name: Install package and dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install . pyinstaller
+      - name: Install Inno Setup
+        uses: crazy-max/ghaction-chocolatey@v1
+        with:
+          args: install innosetup -y --allow-unofficial --force
+
+      - name: Run pyinstaller
+        run: pyinstaller ./ms2rescore.spec --clean --noconfirm
+
+      - name: Test built exe
+        run: dist/ms2rescore/ms2rescore.exe
+
+      - name: Run Inno Setup
+        run: ISCC.exe ./ms2rescore_innosetup.iss /DMyAppVersion=$(ms2rescore -v)
\ No newline at end of file
diff --git a/ms2rescore_innosetup.iss b/ms2rescore_innosetup.iss
index 8bbd2aaa..c1ba28eb 100644
--- a/ms2rescore_innosetup.iss
+++ b/ms2rescore_innosetup.iss
@@ -4,7 +4,7 @@
 #define MyAppExeName "ms2rescore.exe"
 
 [Setup]
-AppId={{2D3D12BD-3AE2-426E-8DE8-092148C12071}
+AppId={2D3D12BD-3AE2-426E-8DE8-092148C12071}
 AppName={#MyAppName}
 AppVersion={#MyAppVersion}
 AppPublisher={#MyAppPublisher}